Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16013

Add color terms for NB1010

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      External

      Description

      Hiroyuki Ikeda (NAOJ) reports the following color terms for the HSC NB1010 filter:

      'N1010': Colorterm(primary="y", secondary="z",c0=0.003607, c1=0.865366, c2=1.271817)
      

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Lauren MacArthur, would you mind having a look at this tiny patch?

          Show
          price Paul Price added a comment - Lauren MacArthur , would you mind having a look at this tiny patch?
          Hide
          lauren Lauren MacArthur added a comment -

          Looks good.  A few nit-picky comments

          Show
          lauren Lauren MacArthur added a comment - Looks good.  A few nit-picky comments you could specify in the commit message title that these are for PS1 the commit message could use some further details (as you’ve provided in others, e.g.  https://github.com/lsst/obs_subaru/commit/0fdf0a33850641fea96739d46975a1375b1465da ), namely the stellar library used in the fit and the fit ranges you should add N1010 to the list in the unittest  here (N387, N718, & N973 should also be added while you’re at it )
          Hide
          price Paul Price added a comment -

          Lauren MacArthur, would you mind taking another look, as I've added a few extras (specifically, some transmission curves).

          I would love to include more details on the origin of the color terms, but I don't have any.

          Show
          price Paul Price added a comment - Lauren MacArthur , would you mind taking another look, as I've added a few extras (specifically, some transmission curves). I would love to include more details on the origin of the color terms, but I don't have any.
          Hide
          price Paul Price added a comment -

          Jenkins passed.

          Show
          price Paul Price added a comment - Jenkins passed.
          Hide
          lauren Lauren MacArthur added a comment -

          I would love to include more details on the origin of the color terms, but I don't have any.
          I can't imagine Ikeda-san would deny you these details...up to you! 

          Show
          lauren Lauren MacArthur added a comment - I would love to include more details on the origin of the color terms, but I don't have any. I can't imagine Ikeda-san would deny you these details...up to you! 
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Lauren MacArthur
            Watchers:
            Lauren MacArthur, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.