Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_subaru
-
Labels:None
-
Team:External
Description
Hiroyuki Ikeda (NAOJ) reports the following color terms for the HSC NB1010 filter:
'N1010': Colorterm(primary="y", secondary="z",c0=0.003607, c1=0.865366, c2=1.271817)
|
Attachments
Activity
Looks good. A few nit-picky comments
- you could specify in the commit message title that these are for PS1
- the commit message could use some further details (as you’ve provided in others, e.g. https://github.com/lsst/obs_subaru/commit/0fdf0a33850641fea96739d46975a1375b1465da), namely the stellar library used in the fit and the fit ranges
- you should add N1010 to the list in the unittest here (N387, N718, & N973 should also be added while you’re at it
)
Lauren MacArthur, would you mind taking another look, as I've added a few extras (specifically, some transmission curves).
I would love to include more details on the origin of the color terms, but I don't have any.
Paul Price
added a comment - Lauren MacArthur , would you mind taking another look, as I've added a few extras (specifically, some transmission curves).
I would love to include more details on the origin of the color terms, but I don't have any. Jenkins passed.
Paul Price
added a comment - Jenkins passed. I would love to include more details on the origin of the color terms, but I don't have any.
I can't imagine Ikeda-san would deny you these details...up to you!
Merged to master.
Paul Price
added a comment - Merged to master. 
Lauren MacArthur, would you mind having a look at this tiny patch?