Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16018

assertAnglesAlmostEqual fails for NaN angles

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: geom
    • Labels:
      None

      Description

      In removing VisitInfo creation from obs_subaru and moving it to obs_base, all the tests passed in test_repository.py despite me not yet calculating an ERA. Turns out that geom.Angle(NaN) compared to a finite Angle is always fine. Fix the assert to trap NaN in either argument.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9707 Please make assertFloatsAlmostEqual more flexible

          • To Do

          Improvement - An improvement or enhancement to an existing feature or task. DM-7276 Use numpy allclose in utils.tests and afw.image.tests and support NaNs

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Epic Link DM-14487 [ 83298 ]
            tjenness Tim Jenness made changes -
            Risk Score 0
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Russell Owen would you be able to do this quick review please? Jenkins is running.

            Show
            tjenness Tim Jenness added a comment - Russell Owen would you be able to do this quick review please? Jenkins is running.
            tjenness Tim Jenness made changes -
            Reviewers Russell Owen [ rowen ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-7276 [ DM-7276 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-9707 [ DM-9707 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Looks good. One small requested addition to the unit test.

            Show
            rowen Russell Owen added a comment - Looks good. One small requested addition to the unit test.
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, John Parejko, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.