Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16018

assertAnglesAlmostEqual fails for NaN angles

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: geom
    • Labels:
      None

      Description

      In removing VisitInfo creation from obs_subaru and moving it to obs_base, all the tests passed in test_repository.py despite me not yet calculating an ERA. Turns out that geom.Angle(NaN) compared to a finite Angle is always fine. Fix the assert to trap NaN in either argument.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9707 Please make assertFloatsAlmostEqual more flexible

          • To Do

          Improvement - An improvement or enhancement to an existing feature or task. DM-7276 Use numpy allclose in utils.tests and afw.image.tests and support NaNs

          • Won't Fix

            Activity

            No builds found.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, John Parejko, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.