Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16056

Make astropy coordinate objects convert directly to SpherePoint in pybind11

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: geom
    • Labels:

      Description

      As discussed on Slack with Tim Jenness, we should

      • convert SkyCoord objects to ICRs (via .transform_to("icrs"))
      • interpret all other coordinate objects as already being in the right frame and just extract their angles directly

      It'd be ideal if we could make this work on arrays/vectors as well.

      This will be especially valuable for a C++ version of obs_metadata's ObservationInfo.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jbosch Jim Bosch added a comment -

          Tim Jenness, do you recall what this ticket was about?  I've forgotten, and I'm not sure if it's something we actually need for Gen3.

          Show
          jbosch Jim Bosch added a comment - Tim Jenness , do you recall what this ticket was about?  I've forgotten, and I'm not sure if it's something we actually need for Gen3.
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          We wanted to begin dropping SpherePoint on the python side and automatically convert a SpherePoint leaving C++ to a SkyCoord and also automatically convert a SkyCoord back to an ICRS SpherePoint when going back to C++.

          Converting when going to C++ seems safe but converting when going from C++ to Python will break a lot of code. I imagine that ObservationInfo vs VisitInfo discussions should be had independently of this ticket.

          Show
          tjenness Tim Jenness added a comment - We wanted to begin dropping SpherePoint on the python side and automatically convert a SpherePoint leaving C++ to a SkyCoord and also automatically convert a SkyCoord back to an ICRS SpherePoint when going back to C++. Converting when going to C++ seems safe but converting when going from C++ to Python will break a lot of code. I imagine that ObservationInfo vs VisitInfo discussions should be had independently of this ticket.

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Watchers:
            Jim Bosch, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Jenkins

                No builds found.