Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16118

Firefly: updating field from fieldgroup reducer function doesn't update the list of ListBoxInputField

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:

      Description

      We were trying to update a field in a component under a fieldgroup form, where the component is expecting to get options list changes based on another field but even though the reducer change the state, the list doesn't get updated.

      When it comes to changing a value, the reducer and the render change it without problem. Seems that is only the ListInputField component with updated options that exposed this problem.

      Please, contact Dean Naji for mor example on how this is failing and how we were expecting to be using it. Thanks.

       

        Attachments

          Activity

          Hide
          tatianag Tatiana Goldina added a comment -

          Dean Naji Please see FieldGroupWithMasterDependent in ExampleDialog.js for an example how the options in a list box can be changed using the reducer function. The important part is not to specify options in render() if you want to control them in reducer function.

          To see a working example in Firefly, use http://localhost:8080/firefly/firefly-dev.html -> "Example Js Dialog" -> "Third" tab.

          Show
          tatianag Tatiana Goldina added a comment - Dean Naji Please see FieldGroupWithMasterDependent in ExampleDialog.js for an example how the options in a list box can be changed using the reducer function. The important part is not to specify options in render() if you want to control them in reducer function. To see a working example in Firefly, use http://localhost:8080/firefly/firefly-dev.html -> "Example Js Dialog" -> "Third" tab.
          Hide
          ejoliet Emmanuel Joliet added a comment -

          Dean Naji Did you follow-up this with Tatiana? Can you or someone update the ticket so we know what needs to be done if any actions remain?

          Show
          ejoliet Emmanuel Joliet added a comment - Dean Naji Did you follow-up this with Tatiana? Can you or someone update the ticket so we know what needs to be done if any actions remain?
          Hide
          dnaji Dean Naji added a comment - - edited

          Yes, I think we are already done with this. Thanks Tatiana Goldina.

          The problem was found with Sofia Instrument, as the reducer function was not re-rendering the options. I think this was fixed. However, in Sofia we still not using the reducer function. We are still forcing the component to re-render.

          Show
          dnaji Dean Naji added a comment - - edited Yes, I think we are already done with this. Thanks Tatiana Goldina . The problem was found with Sofia Instrument, as the reducer function was not re-rendering the options. I think this was fixed. However, in Sofia we still not using the reducer function. We are still forcing the component to re-render.
          Hide
          xiuqin Xiuqin Wu [X] (Inactive) added a comment -

          The SOFIA application needs to be updated to use reducer. An IRSA ticket should be created to address it. 

          Show
          xiuqin Xiuqin Wu [X] (Inactive) added a comment - The SOFIA application needs to be updated to use reducer. An IRSA ticket should be created to address it. 

            People

            • Assignee:
              ejoliet Emmanuel Joliet
              Reporter:
              ejoliet Emmanuel Joliet
              Watchers:
              Dean Naji, Emmanuel Joliet, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel