Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16128

Add fgcm and fgcmcal to lsst_distrib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F18-5, DRP F18-6
    • Team:
      Data Release Production

      Description

      Implementation of RFC-526:

      The FGCM (pure python) third-party package (https://github.com/erykoff/fgcm) will be added to the stack (via a github fork to allow easy continued development), and the fgcmcal package currently hosted by lsst-dm (https://github.com/lsst-dm/fgcmcal) will be moved to lsst_distrib. There are no additional dependencies that will have to be added that are not already in lsst_distrib.

       This ticket adds fgcm and fgcmcal to lsst_distrib

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16397 Do release 17.0 of science pipelines

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-526 Add FGCM as a 3rd party package to the stack and move fgcmcal from lsst-dm to lsst

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I am okay with this if only fgcmcal is added to lsst_distrib. fgcm will turn up automatically.

            Show
            tjenness Tim Jenness added a comment - I am okay with this if only fgcmcal is added to lsst_distrib. fgcm will turn up automatically.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Great. Should I rerun jenkins just in case? (it is in the fgcmcal setupRequired)

            Show
            erykoff Eli Rykoff added a comment - Great. Should I rerun jenkins just in case? (it is in the fgcmcal setupRequired)
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            No need since I think we can tell by inspection that this will be fine. If you really want to check you can ask Jenkins to just build fgcmcal on its own (no need to force a full lsst_distrib build).

            Show
            tjenness Tim Jenness added a comment - No need since I think we can tell by inspection that this will be fine. If you really want to check you can ask Jenkins to just build fgcmcal on its own (no need to force a full lsst_distrib build).
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment - - edited

            The developer guide says:

            New packages must be added to the LSST organization on GitHub and access must be granted to appropriate teams. For DM-written code, these include “Data Management” and “Overlords.” For third-party code, use the “DM Externals” and “Overlords” (but not “Data Management”) teams.

            This wasn't done for fgcm, and so the nightly release build broke.

            Show
            ktl Kian-Tat Lim added a comment - - edited The developer guide says: New packages must be added to the LSST organization on GitHub and access must be granted to appropriate teams. For DM-written code, these include “Data Management” and “Overlords.” For third-party code, use the “DM Externals” and “Overlords” (but not “Data Management”) teams. This wasn't done for fgcm , and so the nightly release build broke.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Kian-Tat Lim I am very sorry about this.  However, I should note that this is not something that Jane Q. Developer has access to, nor is it something that seems to be checkable via github.  I had assumed this was done when whomever had volunteered to help on slack had made the fork (fgcm)/moved the package from lsst-dm (fcgmcal).  That is, if you don't have management access, it is not clear to me where you can check if this was done properly since there isn't a "settings" button if you aren't a manager of the repo.  

            Show
            erykoff Eli Rykoff added a comment - Kian-Tat Lim I am very sorry about this.  However, I should note that this is not something that Jane Q. Developer has access to, nor is it something that seems to be checkable via github.  I had assumed this was done when whomever had volunteered to help on slack had made the fork (fgcm)/moved the package from lsst-dm (fcgmcal).  That is, if you don't have management access, it is not clear to me where you can check if this was done properly since there isn't a "settings" button if you aren't a manager of the repo.  
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            My fault. Sorry. Forgot to do it when I made the fork.

            Show
            tjenness Tim Jenness added a comment - My fault. Sorry. Forgot to do it when I made the fork.

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Tim Jenness
              Watchers:
              Eli Rykoff, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.