Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16128

Add fgcm and fgcmcal to lsst_distrib

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 1
    • DRP F18-5, DRP F18-6
    • Data Release Production

    Description

      Implementation of RFC-526:

      The FGCM (pure python) third-party package (https://github.com/erykoff/fgcm) will be added to the stack (via a github fork to allow easy continued development), and the fgcmcal package currently hosted by lsst-dm (https://github.com/lsst-dm/fgcmcal) will be moved to lsst_distrib. There are no additional dependencies that will have to be added that are not already in lsst_distrib.

       This ticket adds fgcm and fgcmcal to lsst_distrib

      Attachments

        Issue Links

          Activity

            No builds found.
            erykoff Eli Rykoff created issue -
            erykoff Eli Rykoff made changes -
            Field Original Value New Value
            Epic Link DM-14665 [ 108959 ]
            erykoff Eli Rykoff made changes -
            Link This issue is triggered by RFC-526 [ RFC-526 ]
            erykoff Eli Rykoff made changes -
            Risk Score 0
            swinbank John Swinbank made changes -
            Link This issue blocks DM-16397 [ DM-16397 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP F18-5 [ 790 ] DRP F18-5, DRP F18-6 [ 790, 811 ]
            erykoff Eli Rykoff made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            erykoff Eli Rykoff made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            tjenness Tim Jenness added a comment -

            I am okay with this if only fgcmcal is added to lsst_distrib. fgcm will turn up automatically.

            tjenness Tim Jenness added a comment - I am okay with this if only fgcmcal is added to lsst_distrib. fgcm will turn up automatically.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            erykoff Eli Rykoff added a comment -

            Great. Should I rerun jenkins just in case? (it is in the fgcmcal setupRequired)

            erykoff Eli Rykoff added a comment - Great. Should I rerun jenkins just in case? (it is in the fgcmcal setupRequired)
            tjenness Tim Jenness added a comment -

            No need since I think we can tell by inspection that this will be fine. If you really want to check you can ask Jenkins to just build fgcmcal on its own (no need to force a full lsst_distrib build).

            tjenness Tim Jenness added a comment - No need since I think we can tell by inspection that this will be fine. If you really want to check you can ask Jenkins to just build fgcmcal on its own (no need to force a full lsst_distrib build).
            erykoff Eli Rykoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            ktl Kian-Tat Lim added a comment - - edited

            The developer guide says:

            New packages must be added to the LSST organization on GitHub and access must be granted to appropriate teams. For DM-written code, these include “Data Management” and “Overlords.” For third-party code, use the “DM Externals” and “Overlords” (but not “Data Management”) teams.

            This wasn't done for fgcm, and so the nightly release build broke.

            ktl Kian-Tat Lim added a comment - - edited The developer guide says: New packages must be added to the LSST organization on GitHub and access must be granted to appropriate teams. For DM-written code, these include “Data Management” and “Overlords.” For third-party code, use the “DM Externals” and “Overlords” (but not “Data Management”) teams. This wasn't done for fgcm , and so the nightly release build broke.
            erykoff Eli Rykoff added a comment -

            ktl I am very sorry about this.  However, I should note that this is not something that Jane Q. Developer has access to, nor is it something that seems to be checkable via github.  I had assumed this was done when whomever had volunteered to help on slack had made the fork (fgcm)/moved the package from lsst-dm (fcgmcal).  That is, if you don't have management access, it is not clear to me where you can check if this was done properly since there isn't a "settings" button if you aren't a manager of the repo.  

            erykoff Eli Rykoff added a comment - ktl I am very sorry about this.  However, I should note that this is not something that Jane Q. Developer has access to, nor is it something that seems to be checkable via github.  I had assumed this was done when whomever had volunteered to help on slack had made the fork (fgcm)/moved the package from lsst-dm (fcgmcal).  That is, if you don't have management access, it is not clear to me where you can check if this was done properly since there isn't a "settings" button if you aren't a manager of the repo.  
            tjenness Tim Jenness added a comment -

            My fault. Sorry. Forgot to do it when I made the fork.

            tjenness Tim Jenness added a comment - My fault. Sorry. Forgot to do it when I made the fork.

            People

              erykoff Eli Rykoff
              erykoff Eli Rykoff
              Tim Jenness
              Eli Rykoff, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.