Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16159

Revert DM-15686 to un-break obs_subaru master

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Sprint:
      BG3_F18_10
    • Team:
      Data Release Production

      Description

      The change to how we detect uniqueness violations in associate broke the Gen3 ingest tests in obs_subaru, because those rely (probably unwisely) on detecting the conflict before a transaction rollback is initiated.

      The correct fix for this may be in obs_base (where most of Gen3 ingest is implemented), but if so, it's non-trivial, and master is broken right now.  The easy way to un-break it is to revert the merge of DM-15686 is daf_butler.

       

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Epic Link DM-14448 [ 80390 ]
            jbosch Jim Bosch made changes -
            Link This issue is triggered by DM-15686 [ DM-15686 ]
            jbosch Jim Bosch made changes -
            Risk Score 0
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master sans review after local testing strongly indicated this would fix master.

            Show
            jbosch Jim Bosch added a comment - Merged to master sans review after local testing strongly indicated this would fix master.
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            Hide
            salnikov Andy Salnikov added a comment -

            Sorry for my mess, I just realized that I forgot to run Jenkins (I need more practice breaking things, then probably I remember it better).
            The uniqueness test was happening in addDataset() and I have moved it to associate(), one way to restore old behavior is to keep the test in addDataset() (and then repeat it in associate()). I can test this tomorrow.

            Show
            salnikov Andy Salnikov added a comment - Sorry for my mess, I just realized that I forgot to run Jenkins (I need more practice breaking things, then probably I remember it better). The uniqueness test was happening in addDataset() and I have moved it to associate() , one way to restore old behavior is to keep the test in addDataset() (and then repeat it in associate() ). I can test this tomorrow.
            salnikov Andy Salnikov made changes -
            Link This issue is triggering DM-16160 [ DM-16160 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-16221 [ DM-16221 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Andy Salnikov, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.