Change log level to WARN for the footprint skipping

XMLWordPrintable

Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Sprint:
DRP F19-2
• Team:
Data Release Production

Description

The current log level for noting that a footprint is getting skipped is at log.trace, so this information does not get printed to the logs. This is an useful and important piece of processing information, so should be set to WARN at these two locations:
https://github.com/lsst/meas_deblender/blob/master/python/lsst/meas/deblender/deblend.py#L297
https://github.com/lsst/meas_deblender/blob/master/python/lsst/meas/deblender/deblend.py#L302
See DM-16151 for more details.

Activity

Hide
Lauren MacArthur added a comment - - edited

Would you mind giving this a look? The following is an example of the WARN that will now be printed to the log when a footprint is skipped:

 multiBandDriver.deblendCoaddSources.singleBandDeblend WARN: Parent 43159138515025921: skipping large footprint (area: 2018438) 

Unfortunately, it looks like no dataId information is passed to the deblender, so I can't print that info along with the warning (as was requested by Hisanori Furusawa on #subaru-hsc). I also tried printing out the ra & dec of the src, but it seems those fields are still populated with nan in the deblending phase. So, for now, one will have to use the parentId to trace back to footprint’s location. Passing in the dataId info would be an API change (requiring and RFC process), so would need to be requested to go any further, but at least getting a warning in the logs is an improvement.

A Jenkins run with

 PRODUCTS: lsst_distrib lsst_ci ci_hsc REFS: tickets/DM-16179 

over the weekend was green. Just to be sure, I've kicked off another one.

Show
Lauren MacArthur added a comment - - edited Would you mind giving this a look? The following is an example of the WARN that will now be printed to the log when a footprint is skipped: multiBandDriver.deblendCoaddSources.singleBandDeblend WARN: Parent 43159138515025921: skipping large footprint (area: 2018438) Unfortunately, it looks like no dataId information is passed to the deblender, so I can't print that info along with the warning (as was requested by Hisanori Furusawa on #subaru-hsc). I also tried printing out the ra & dec of the src, but it seems those fields are still populated with nan in the deblending phase. So, for now, one will have to use the parentId to trace back to footprint’s location. Passing in the dataId info would be an API change (requiring and RFC process), so would need to be requested to go any further, but at least getting a warning in the logs is an improvement. A Jenkins run with PRODUCTS: lsst_distrib lsst_ci ci_hsc REFS: tickets/DM-16179 over the weekend was green . Just to be sure, I've kicked off another one .
Hide
Paul Price added a comment -

Looks good.

Show
Paul Price added a comment - Looks good.
Hide
Lauren MacArthur added a comment -

Thanks for the quick review.  I waited out the final Jenkins (green) and merged to master.

Show
Lauren MacArthur added a comment - Thanks for the quick review.  I waited out the final Jenkins (green) and merged to master.

People

Assignee:
Lauren MacArthur
Reporter:
Lauren MacArthur
Reviewers:
Paul Price
Watchers:
Jim Bosch, Lauren MacArthur, Paul Price, Yusra AlSayyad