Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16208

Add magnitudeToInstFlux method that takes a Point to PhotoCalib

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      For fake source injection, we should be able to place a source at a specific pixel location, which means we need a way to convert a magnitude to an instrumental flux at that location. The existing magnitudeToInstFlux method only works with the mean calibration, but should be overloaded to also take a Point (the desired location of the fake source).

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15514 Write insertFakeObjectsTask to add fake sources for QA purposes.

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Sophie Reed: since you requested this, do you mind reviewing it? It's a small change, but mostly C++ code (plus python tests).

            Show
            Parejkoj John Parejko added a comment - Sophie Reed : since you requested this, do you mind reviewing it? It's a small change, but mostly C++ code (plus python tests).
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Oh, and here's the PR, since Jira isn't picking it up: https://github.com/lsst/afw/pull/412

            Also, Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28987/pipeline

            Show
            Parejkoj John Parejko added a comment - Oh, and here's the PR, since Jira isn't picking it up: https://github.com/lsst/afw/pull/412 Also, Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28987/pipeline
            Hide
            Permalink
            sophiereed Sophie Reed added a comment -

            Thank you for adding this, it looks fine to me.

            Show
            sophiereed Sophie Reed added a comment - Thank you for adding this, it looks fine to me.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Sophie Reed
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Sophie Reed
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.