Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16220

Use modern subprocess.run in sconsUtils

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Arch 2018-10-22, Arch 2018-10-29
    • Team:
      Architecture

      Description

      sconsUtils is using some subprocess.Popen calls directly. In some cases this leads to an open file descriptor on error. Rewrite to use subprocess.run.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          tjenness Tim Jenness created issue -
          tjenness Tim Jenness made changes -
          Field Original Value New Value
          Risk Score 0
          tjenness Tim Jenness made changes -
          Assignee Tim Jenness [ tjenness ]
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Minor cleanup of subprocess usage. Mainly driven by problem Gabriele Comoretto [X] was seeing in his conda builds.

          Show
          tjenness Tim Jenness added a comment - Minor cleanup of subprocess usage. Mainly driven by problem Gabriele Comoretto [X] was seeing in his conda builds.
          tjenness Tim Jenness made changes -
          Reviewers Kian-Tat Lim [ ktl ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Needs some more work... But overall the idea is fine.

          Show
          ktl Kian-Tat Lim added a comment - Needs some more work... But overall the idea is fine.
          ktl Kian-Tat Lim made changes -
          Sprint Arch 2018-10-22 [ 799 ] Arch 2018-10-22, Arch 2018-10-29 [ 799, 801 ]
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          I've tweaked it so it works. I'll tweak it again when we move to python 3.7. Please move the ticket out of review if you are happy for me to merge.

          Show
          tjenness Tim Jenness added a comment - I've tweaked it so it works. I'll tweak it again when we move to python 3.7. Please move the ticket out of review if you are happy for me to merge.
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Looks OK.

          Show
          ktl Kian-Tat Lim added a comment - Looks OK.
          ktl Kian-Tat Lim made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Reworked to support python 3.6. Jenkins passed.

          Show
          tjenness Tim Jenness added a comment - Reworked to support python 3.6. Jenkins passed.
          tjenness Tim Jenness made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Kian-Tat Lim
            Watchers:
            Gabriele Comoretto [X] (Inactive), Kian-Tat Lim, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.