Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16294

Fix coadd dataset templates in obs_lsst and possibly elsewhere

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      obs_lsst has some unnecessary overrides of obs_base datasets and some datasets that probably shouldn't exist at all.  For the latter we should try to track down where they were cargo-culted from as well.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Epic Link DM-14405 [ 79812 ]
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            jbosch Jim Bosch added a comment -

            Ian Sullivan, could you take a look at these obs_* package dataset type changes?  I think you were the last person to attempt something like this in obs_lsstCam, and you're certainly in the best position to check dcrCoadd things.

            On that note, there are also some dcrCoadd definitions in obs_decam that look suspicious to me, but I'm not sure what to change them to (unless it's to delete them so the obs_base ones are used).  I have not made those changes on this ticket but would be happy to if you can point me in the right direction.

            PRs are:

            I am under no illusions that this fixes all problems with dataset type definitions, but I didn't want to change anything that could be backwards incompatible (i.e. changing a template definition) unless I was certain it was already broken (aside from obs_lsstCam, where I'm explicitly trying to get things in shape for better future compatibility).

            I'd recommend looking at these commit-by-commit.

            Show
            jbosch Jim Bosch added a comment - Ian Sullivan , could you take a look at these obs_* package dataset type changes?  I think you were the last person to attempt something like this in obs_lsstCam, and you're certainly in the best position to check dcrCoadd things. On that note, there are also some dcrCoadd definitions in obs_decam that look suspicious to me, but I'm not sure what to change them to (unless it's to delete them so the obs_base ones are used).  I have not made those changes on this ticket but would be happy to if you can point me in the right direction. PRs are: https://github.com/lsst/obs_base/pull/118 https://github.com/lsst/obs_decam/pull/95 https://github.com/lsst/obs_lsstCam/pull/34 https://github.com/lsst/obs_lsstSim/pull/78 https://github.com/lsst/obs_sdss/pull/57 https://github.com/lsst/obs_subaru/pull/161 https://github.com/lsst/obs_cfht/pull/51 I am under no illusions that this fixes all problems with dataset type definitions, but I didn't want to change anything that could be backwards incompatible (i.e. changing a template definition) unless I was certain it was already broken (aside from obs_lsstCam, where I'm explicitly trying to get things in shape for better future compatibility). I'd recommend looking at these commit-by-commit.
            jbosch Jim Bosch made changes -
            Reviewers Ian Sullivan [ sullivan ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            sullivan Ian Sullivan added a comment -

            I've tested the changes for `obs_lsstSim` along with the additional deletions I suggested on the PR, and everything appears to work. Some metadata had before been persisted in the wrong place, and is now persisted correctly.

            Show
            sullivan Ian Sullivan added a comment - I've tested the changes for `obs_lsstSim` along with the additional deletions I suggested on the PR, and everything appears to work. Some metadata had before been persisted in the wrong place, and is now persisted correctly.
            sullivan Ian Sullivan made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Component/s obs_lsst [ 16504 ]
            Component/s obs_lsstCam [ 15215 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-10994 [ DM-10994 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Ian Sullivan
              Watchers:
              Ian Sullivan, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.