Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_association
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:AP F18-6
-
Team:Alert Production
Description
The new API of ap_association in DM-15588 assumes that all SourceCatalogs fed into are calibrated data products with column names close to that of the DPDD and Ppdb schema.
This ticket creates a task to convert outputs from ip_diffim into a usable format for ap_association to be use in association and set to the PPDB to be written.
Attachments
Activity
You call it a placeholder because you need something to load into the ppdb now. For that purpose this looks fine. I worry about extensibility in the future.
For what it's worth, I agree with that concern, but also with your reading of the priorities. We're waiting to see what comes out of DM-14568 before doing anything too substantial here.
See notes in github
Hey Yusra AlSayyad, take a my new commits and let me know if I've missed anything. I'll rebase once I hear back from ya. Jenkins job submitted.
OK to squash and merge
Still haven't found the time for a line review. Some comments after skimming it.
1) Just recently approved by the change control board, we're providing fluxes in NanoJanskys rather than NanoMaggies.
2) Looks like you have two types of operations to columns now: Copy and InstFluxToMaggies. Is the design that for each new type of operation on a column, you add a new config parameter with a list of those columns? What happens if you have an operation that requires two columns. e.g. XYErr to Ra/DecErr?
You call it a placeholder because you need something to load into the ppdb now. For that purpose this looks fine. I worry about extensibility in the future.