Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16305

Implement bbox integrator for PhotometryTransform

    XMLWordPrintable

    Details

      Description

      I implemented a stop-gap solution to DM-16235 (using the original calibration for the mean calibration so that mean calibrations are never negative). This ticket is to finish the integration code that was started there, so that we can compare the jointcal means with the original processCcd calibration means.

      Jim Bosch suggests using the Chebyshev1dBasis in lsst.geom.polynomials to help implement the integration code.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16235 Jointcal PhotoCalib returns negative calibrations

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jim Bosch: do you mind looking at this medium-sized review? It's about 250 lines of important changes: it'll be clearest if you do it by commit, since some of the commits are just renames and/or a bit of post-DM-13976 cleanup.

            You had some suggestions about how to use the recurrence relations in the new polynomials code, but I wasn't sure how to go about it, so feel free to put those in the review.

            Show
            Parejkoj John Parejko added a comment - Jim Bosch : do you mind looking at this medium-sized review? It's about 250 lines of important changes: it'll be clearest if you do it by commit, since some of the commits are just renames and/or a bit of post- DM-13976 cleanup. You had some suggestions about how to use the recurrence relations in the new polynomials code, but I wasn't sure how to go about it, so feel free to put those in the review.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29110/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29110/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the rapid review. I incorporated your comments and squashed.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the rapid review. I incorporated your comments and squashed. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.