Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16338

Add fluxErr to LoadReferenceObjectsTask makeMinimalSchema

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F18-6, AP S19-1
    • Team:
      Alert Production

      Description

      Adding fluxErr to LoadReferenceObjectsTask.makeMinimalSchema() helps with some of the problem posed in RFC-535, while being uncontroversial. This will ensure that future reference catalogs have this field by default.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-535 Make flux error a required field in reference catalogs

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I've removed the addFluxErr option, making it always True. I'll see if anything in Jenkins complains before sending it for review.

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29082/pipeline

            Show
            Parejkoj John Parejko added a comment - I've removed the addFluxErr option, making it always True . I'll see if anything in Jenkins complains before sending it for review. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29082/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Simon Krughoff: can you review this small change? This implements what I believe is an uncontroversial part of RFC-535, by removing the option to make refcats without fluxErr.

            Show
            Parejkoj John Parejko added a comment - Simon Krughoff : can you review this small change? This implements what I believe is an uncontroversial part of RFC-535 , by removing the option to make refcats without fluxErr.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            See one small comment in the PRs.

            My only other concern is that brought up on the RFC. I.e. how do old catalogs get brought forward?

            Otherwise LGTM.

            Show
            krughoff Simon Krughoff added a comment - See one small comment in the PRs. My only other concern is that brought up on the RFC. I.e. how do old catalogs get brought forward? Otherwise LGTM.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review.

            This doesn't have any impact on existing catalogs, just new ones we create from now on.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review. This doesn't have any impact on existing catalogs, just new ones we create from now on. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Simon Krughoff
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.