[DM-16505] Docstring for pex_config Fields does not take into account optional status - Jira

XML

Word

Printable

Details

Type: Improvement
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: pex_config
Labels:
None

Team:
Architecture

Description

When a field is not optional (the default), the docstring should not include the (unused) default value of None.

Attachments

Activity

Ascending order - Click to sort in descending order

No builds found.

Kian-Tat Lim created issue - 14/Nov/18 2:16 PM

Hide

Permalink

Kian-Tat Lim added a comment - 14/Nov/18 2:20 PM

Jenkins is running, but I don't expect problems.

Show

Kian-Tat Lim added a comment - 14/Nov/18 2:20 PM Jenkins is running, but I don't expect problems.

Kian-Tat Lim made changes - 14/Nov/18 2:20 PM

Field	Original Value	New Value
Reviewers		Krzysztof Findeisen [ krzys ]
Status	To Do [ 10001 ]	In Review [ 10004 ]

Hide

Permalink

Krzysztof Findeisen added a comment - 14/Nov/18 2:49 PM

Looks good!

Show

Krzysztof Findeisen added a comment - 14/Nov/18 2:49 PM Looks good!

Krzysztof Findeisen made changes - 14/Nov/18 2:49 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Kian-Tat Lim made changes - 14/Nov/18 2:58 PM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

People

Assignee:: Kian-Tat Lim

Reporter:: Kian-Tat Lim

Reviewers:: Krzysztof Findeisen

Watchers:: Kian-Tat Lim, Krzysztof Findeisen

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 14/Nov/18 2:16 PM

Updated:: 14/Nov/18 2:58 PM

Resolved:: 14/Nov/18 2:58 PM

Jenkins