Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16550

Races in YAML tests in daf_persistence

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_persistence
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Arch 2018-11-12
    • Team:
      Architecture

      Description

      The YAML storage tests in daf_persistence create a temporary directory but do not use it. This leads to test failures when the tests are run in parallel. Also fix the pickle test so that it no longer uses the root directory.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          Kian-Tat Lim would you mind doing a quick review of this? It fixes the problem John Swinbank was encountering with the shared stack. I'm guessing that Jenkins does not show the problem because it uses fewer cores so is more likely to place both YAML tests in the same process.

          Show
          tjenness Tim Jenness added a comment - Kian-Tat Lim would you mind doing a quick review of this? It fixes the problem John Swinbank was encountering with the shared stack. I'm guessing that Jenkins does not show the problem because it uses fewer cores so is more likely to place both YAML tests in the same process.
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Looks fine.

          Show
          ktl Kian-Tat Lim added a comment - Looks fine.

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Kian-Tat Lim
            Watchers:
            John Swinbank, Kian-Tat Lim, Nate Pease [X] (Inactive), Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.