Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16550

Races in YAML tests in daf_persistence

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • daf_persistence
    • None
    • 0.5
    • Arch 2018-11-12
    • Architecture

    Description

      The YAML storage tests in daf_persistence create a temporary directory but do not use it. This leads to test failures when the tests are run in parallel. Also fix the pickle test so that it no longer uses the root directory.

      Attachments

        Activity

          tjenness Tim Jenness added a comment -

          ktl would you mind doing a quick review of this? It fixes the problem swinbank was encountering with the shared stack. I'm guessing that Jenkins does not show the problem because it uses fewer cores so is more likely to place both YAML tests in the same process.

          tjenness Tim Jenness added a comment - ktl would you mind doing a quick review of this? It fixes the problem swinbank was encountering with the shared stack. I'm guessing that Jenkins does not show the problem because it uses fewer cores so is more likely to place both YAML tests in the same process.
          ktl Kian-Tat Lim added a comment -

          Looks fine.

          ktl Kian-Tat Lim added a comment - Looks fine.

          People

            tjenness Tim Jenness
            tjenness Tim Jenness
            Kian-Tat Lim
            John Swinbank, Kian-Tat Lim, Nate Pease [X] (Inactive), Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.