Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: faro, validate_drp
-
Labels:None
-
Story Points:0.2
-
Epic Link:
-
Team:DM Science
-
Urgent?:No
Description
Alexandre Ciulli kindly points out that there's an indexing error in calcRmsDistances
1. Update validate_drp/python/lsst/validate/drp/calcsrd/amx.py to add back in the index offset in line 198-199
dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
|
objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
|
(dist < annulusRadians[1]))
|
to
dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
|
objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
|
(dist < annulusRadians[1]))
|
objectsInAnnulus += obj1 + 1
|
Or generalize/refactor in some other way to capture the index offset correctly.
validate_drp has been replaced by faro, there will be no further development in validate_drp. This error however seems to have been propagated to faro.