Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16556

calcRmsDistances is comparing objects in correct distances due to indexing error

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • faro, validate_drp
    • None

    Description

      Alexandre Ciulli kindly points out that there's an indexing error in calcRmsDistances

      1. Update validate_drp/python/lsst/validate/drp/calcsrd/amx.py to add back in the index offset in line 198-199

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
      

      to

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
              objectsInAnnulus += obj1 + 1
      

      Or generalize/refactor in some other way to capture the index offset correctly.

      Attachments

        Activity

          lguy Leanne Guy added a comment -

          validate_drp has been replaced by faro, there will be no further development in validate_drp. This error however seems to have been propagated to faro.

          lguy Leanne Guy added a comment - validate_drp has been replaced by faro, there will be no further development in validate_drp. This error however seems to have been propagated to faro.

          The proposed change does indeed fix the issue. We may want to refactor this code to something more readable, but for now I have confirmed that the solution above works.

          jcarlin Jeffrey Carlin added a comment - The proposed change does indeed fix the issue. We may want to refactor this code to something more readable, but for now I have confirmed that the solution above works.
          lguy Leanne Guy added a comment -

          Detailed comments provided in PR

          lguy Leanne Guy added a comment - Detailed comments provided in PR

          People

            jcarlin Jeffrey Carlin
            wmwood-vasey Michael Wood-Vasey
            Leanne Guy
            Jeffrey Carlin, Keith Bechtol, Leanne Guy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.