Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: faro, validate_drp
-
Labels:None
-
Story Points:0.2
-
Epic Link:
-
Team:DM Science
-
Urgent?:No
Description
Alexandre Ciulli kindly points out that there's an indexing error in calcRmsDistances
1. Update validate_drp/python/lsst/validate/drp/calcsrd/amx.py to add back in the index offset in line 198-199
dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
|
objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
|
(dist < annulusRadians[1]))
|
to
dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
|
objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
|
(dist < annulusRadians[1]))
|
objectsInAnnulus += obj1 + 1
|
Or generalize/refactor in some other way to capture the index offset correctly.
Attachments
Activity
Michael Wood-Vasey
created issue -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Michael Wood-Vasey [X] [ wmwood-vasey ] | Leanne Guy [ lguy ] |
| Component/s | faro [ 19203 ] | |
| Epic Link |
|
|
| Team | SQuaRE [ 10302 ] | DM Science [ 12218 ] |
| Urgent? | off | |
| Watchers | Michael Wood-Vasey [X] [ Michael Wood-Vasey [X] ] | Jeffrey Carlin, Keith Bechtol [ Jeffrey Carlin, Keith Bechtol ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Assignee | Leanne Guy [ lguy ] | Jeffrey Carlin [ jcarlin ] |
The proposed change does indeed fix the issue. We may want to refactor this code to something more readable, but for now I have confirmed that the solution above works.
| Reviewers | Leanne Guy [ lguy ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Detailed comments provided in PR
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
validate_drp has been replaced by faro, there will be no further development in validate_drp. This error however seems to have been propagated to faro.