Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16556

calcRmsDistances is comparing objects in correct distances due to indexing error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: faro, validate_drp
    • Labels:
      None

      Description

      Alexandre Ciulli kindly points out that there's an indexing error in calcRmsDistances

      1. Update validate_drp/python/lsst/validate/drp/calcsrd/amx.py to add back in the index offset in line 198-199

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
      

      to

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
              objectsInAnnulus += obj1 + 1
      

      Or generalize/refactor in some other way to capture the index offset correctly.

        Attachments

          Activity

          wmwood-vasey Michael Wood-Vasey created issue -
          lguy Leanne Guy made changes -
          Field Original Value New Value
          Assignee Michael Wood-Vasey [X] [ wmwood-vasey ] Leanne Guy [ lguy ]
          lguy Leanne Guy made changes -
          Component/s faro [ 19203 ]
          Epic Link DM-26993 [ 440193 ]
          Team SQuaRE [ 10302 ] DM Science [ 12218 ]
          Urgent? off
          Watchers Michael Wood-Vasey [X] [ Michael Wood-Vasey [X] ] Jeffrey Carlin, Keith Bechtol [ Jeffrey Carlin, Keith Bechtol ]
          lguy Leanne Guy made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          lguy Leanne Guy made changes -
          Assignee Leanne Guy [ lguy ] Jeffrey Carlin [ jcarlin ]
          jcarlin Jeffrey Carlin made changes -
          Reviewers Leanne Guy [ lguy ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          lguy Leanne Guy made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          jcarlin Jeffrey Carlin made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            jcarlin Jeffrey Carlin
            Reporter:
            wmwood-vasey Michael Wood-Vasey
            Reviewers:
            Leanne Guy
            Watchers:
            Jeffrey Carlin, Keith Bechtol, Leanne Guy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.