Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16556

calcRmsDistances is comparing objects in correct distances due to indexing error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: faro, validate_drp
    • Labels:
      None

      Description

      Alexandre Ciulli kindly points out that there's an indexing error in calcRmsDistances

      1. Update validate_drp/python/lsst/validate/drp/calcsrd/amx.py to add back in the index offset in line 198-199

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
      

      to

              dist = sphDist(ra1, dec1, meanRa[obj1+1:], meanDec[obj1+1:])
              objectsInAnnulus, = np.where((annulusRadians[0] <= dist) &
                                           (dist < annulusRadians[1]))
              objectsInAnnulus += obj1 + 1
      

      Or generalize/refactor in some other way to capture the index offset correctly.

        Attachments

          Activity

          No work has yet been logged on this issue.

            People

            Assignee:
            jcarlin Jeffrey Carlin
            Reporter:
            wmwood-vasey Michael Wood-Vasey
            Reviewers:
            Leanne Guy
            Watchers:
            Jeffrey Carlin, Keith Bechtol, Leanne Guy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.