Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16557

Move ap_verify_queries function into Ppdb

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      AP S19-6, AP F19-1
    • Team:
      Alert Production

      Description

      DM-15588 removed the placeholder database APIs from ap_association, pipe, and verify. In doing this, a convenience function was created to compute a summary metric on the PPDB for use in ap_verify. This ticket will move that function and it's unittest into the Ppdb class and modifies ap_verify's usage of the function.

        Attachments

          Issue Links

            Activity

            No builds found.
            cmorrison Chris Morrison [X] (Inactive) created issue -
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-14447 [ 80385 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Link This issue is triggered by DM-15588 [ DM-15588 ]
            swinbank John Swinbank made changes -
            Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
            ebellm Eric Bellm made changes -
            Summary Move ap_verify_queries funciton into Ppdb Move ap_verify_queries function into Ppdb
            swinbank John Swinbank made changes -
            Sprint AP S19-4 [ 832 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-4 [ 832 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-6 [ 834 ]
            swinbank John Swinbank made changes -
            Rank Ranked lower
            swinbank John Swinbank made changes -
            Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-6 [ 834 ] AP S19-6, AP F19-1 [ 834, 923 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-6, AP F19-1 [ 834, 923 ] AP S19-6, AP F19-1, AP F19-2 [ 834, 923, 940 ]
            Hide
            swinbank John Swinbank added a comment -

            Agreed with Chris Morrison [X] and Eric Bellm on 2019-07-23 that this is not a current priority; dropping from the sprint.

            Show
            swinbank John Swinbank added a comment - Agreed with Chris Morrison [X] and Eric Bellm on 2019-07-23 that this is not a current priority; dropping from the sprint.
            swinbank John Swinbank made changes -
            Sprint AP S19-6, AP F19-1, AP F19-2 [ 834, 923, 940 ] AP S19-6, AP F19-1 [ 834, 923 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Story Points 2 4
            Hide
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Worked on this as Andy Salnikov is reworking Ppdb and would like to see these queries in the code so he can incorporate in the future version.

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30264/pipeline

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Worked on this as Andy Salnikov is reworking Ppdb and would like to see these queries in the code so he can incorporate in the future version. Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30264/pipeline
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Story Points 4 2
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Reviewers Andy Salnikov [ salnikov ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            For some reason only one pull request is showing up but they are all there.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - For some reason only one pull request is showing up but they are all there.
            Hide
            salnikov Andy Salnikov added a comment -

            Approved all three PRs, looks like a straightforward change. For non-SQL backend some verification-related queries may be less trivial to implement due to very different data organization. Once I have something ready we'll probably need to talk about that to see what could be done about that.

            Show
            salnikov Andy Salnikov added a comment - Approved all three PRs, looks like a straightforward change. For non-SQL backend some verification-related queries may be less trivial to implement due to very different data organization. Once I have something ready we'll probably need to talk about that to see what could be done about that.
            salnikov Andy Salnikov made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Cool, thanks Andy. I'm not 100% sure, but I think at least the "nUnassociated" could be run on the LastDiaObject table instead of the full one if that makes things easier (and if that table is sticking around). The isVisitProcessed query will also get easier once we have a ccdVisit table somewhere. Not sure what else we'll end up needing for verify but that will be mostly up to Eric Bellm.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Cool, thanks Andy. I'm not 100% sure, but I think at least the "nUnassociated" could be run on the LastDiaObject table instead of the full one if that makes things easier (and if that table is sticking around). The isVisitProcessed query will also get easier once we have a ccdVisit table somewhere. Not sure what else we'll end up needing for verify but that will be mostly up to Eric Bellm .
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Chris Morrison [X] (Inactive), John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.