Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: dax_ppdb
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:AP S19-6, AP F19-1
-
Team:Alert Production
Description
DM-15588 removed the placeholder database APIs from ap_association, pipe, and verify. In doing this, a convenience function was created to compute a summary metric on the PPDB for use in ap_verify. This ticket will move that function and it's unittest into the Ppdb class and modifies ap_verify's usage of the function.
Attachments
Issue Links
- is triggered by
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Summary | Move ap_verify_queries funciton into Ppdb | Move ap_verify_queries function into Ppdb |
| Sprint | AP S19-4 [ 832 ] |
| Sprint | AP S19-4 [ 832 ] |
| Sprint | AP S19-6 [ 834 ] |
| Rank | Ranked lower |
| Sprint | AP S19-6 [ 834 ] | AP S19-6, AP F19-1 [ 834, 923 ] |
| Sprint | AP S19-6, AP F19-1 [ 834, 923 ] | AP S19-6, AP F19-1, AP F19-2 [ 834, 923, 940 ] |
| Sprint | AP S19-6, AP F19-1, AP F19-2 [ 834, 923, 940 ] | AP S19-6, AP F19-1 [ 834, 923 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Story Points | 2 | 4 |
Worked on this as Andy Salnikov is reworking Ppdb and would like to see these queries in the code so he can incorporate in the future version.
| Story Points | 4 | 2 |
| Reviewers | Andy Salnikov [ salnikov ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
For some reason only one pull request is showing up but they are all there.
Approved all three PRs, looks like a straightforward change. For non-SQL backend some verification-related queries may be less trivial to implement due to very different data organization. Once I have something ready we'll probably need to talk about that to see what could be done about that.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Cool, thanks Andy. I'm not 100% sure, but I think at least the "nUnassociated" could be run on the LastDiaObject table instead of the full one if that makes things easier (and if that table is sticking around). The isVisitProcessed query will also get easier once we have a ccdVisit table somewhere. Not sure what else we'll end up needing for verify but that will be mostly up to Eric Bellm.
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Agreed with Chris Morrison [X] and Eric Bellm on 2019-07-23 that this is not a current priority; dropping from the sprint.