Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:DRP F18-6
-
Team:Data Release Production
Description
In perusing the stack for examples of mask usage and manipulation, I came across this funtction:
https://github.com/lsst/afw/blob/master/python/lsst/afw/image/image/multiband.py#L481-L490
It looks like there are two issues with it:
1) lsst.afw.image.MaskX has no attribute removeMaskPlaneDict, so any call to the function results in:
AttributeError: type object 'lsst.afw.image.image.image.MaskX' has no attribute 'removeMaskPlaneDict' |
The fix appears to be removeMaskPlaneDict --> removeMaskPlane
2) the function ignores the variable name, i.e. does not pass it to the call to [_sic_!] removeMaskPlaneDict(). Having corrected the function name to removeMaskPlane, the we get the following:
TypeError: removeMaskPlane(): incompatible function arguments. The following argument types are supported:
|
1. (arg0: str) -> None |
The fix here is to pass name to the function.
Finally, I also noticed that the MultibandMask class is missing the removeAndClearMaskPlane() function. I don't think this was intentional, so one should be added.
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Reviewers | Ian Sullivan [ sullivan ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Resolution | Done [ 10000 ] | |
Status | Reviewed [ 10101 ] | Done [ 10002 ] |
I've pretty much had to fix these bugs in trying to figure out how things work, so I'm just picking it up now.