Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16591

Better management of un-created warps

    XMLWordPrintable

    Details

      Description

      Hsin-Fang Chiang's comment on this PR suggests improvements that could be made in makeCoadTempExp.runDataRef(), to better manage failed warps. run() can likely do a better job reporting why a warp wasn't created (e.g. raising a custom exception, vs. returning None), so that we don't get so many spurious warnings.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14286 CompareWarpAssembleCoadd RuntimeError when No PsfMatched warps found at edge cases

          • To Do

          Bug - A problem which impairs or prevents the functions of the product. DM-16537 Fix masked exceptions in makeCoaddTempExp

          • In Review
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Does the reference to runDataRef here imply that this is gen2 only and we should mark as won't fix?

            Show
            tjenness Tim Jenness added a comment - Does the reference to runDataRef here imply that this is gen2 only and we should mark as won't fix?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            This definitely still applies: MakeCoaddTempExp.run has two except Exception as e blocks that just log a warning and continue. I suspect much of that logic was moved out of runDataRef and into run during the gen3 transition, but we still need to handle errors better inside it.

            Show
            Parejkoj John Parejko added a comment - This definitely still applies: MakeCoaddTempExp.run has two  except Exception as e blocks that just log a warning and continue. I suspect much of that logic was moved out of runDataRef and into run during the gen3 transition, but we still need to handle errors better inside it.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I don't think this ticket will be particularly useful in terms of causing the problem to be fixed - I think that'll most like happen along with other structural changes to the coaddition code with other goals in mind - but since I don't have a replacement, we might as well keep the ticket around to remind us that it's a problem.

            Show
            jbosch Jim Bosch added a comment - I don't think this ticket will be particularly useful in terms of causing the problem to be fixed - I think that'll most like happen along with other structural changes to the coaddition code with other goals in mind - but since I don't have a replacement, we might as well keep the ticket around to remind us that it's a problem.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, John Parejko, Lauren MacArthur, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.