Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16598

Add PhotoCalib.calibrateImage() option to compute variance without calib err term

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      Currently PhotoCalib.calibrateImage() computes the variance plane as:

      fluxVar = instFlux.variance * scaleVar +  instFlux.variance * scale**2 + instFlux.image**2 * scaleVar
      

      where scale and scaleVar are my own names for the scale factor that the photocalib applies and the measured uncertainty on that photocalib.

      This equation assumes that the scale factor variance and the image variance are independent, and this isn't obviously true.

      Whether this is the correct variance equation is irrelevant, however. It is a change to how the variance plane in the zeropoint-normalized warps is currently computed, and I suspect it is the primary source of the photometry differences we're seeing in coadds produced with jointcal. While we are testing the effects of using jointcal vs. meas_mosaic's calibration on coadd (DM-16596), it is important that we are able to test these two changes (jointcal's calibrations and the variance plane equation change) separately.

      Implementation: This could be done with an extra argument like photoCalib.calibrateImage(Image, addCalibVar=False or with a state switch like Calib's Calib.setThrowOnNegativeFlux(False).

        Attachments

          Issue Links

            Activity

            yusra Yusra AlSayyad created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Watchers Jim Bosch, Lauren MacArthur, Yusra AlSayyad [ Jim Bosch, Lauren MacArthur, Yusra AlSayyad ] Jim Bosch, John Swinbank, Lauren MacArthur, Yusra AlSayyad [ Jim Bosch, John Swinbank, Lauren MacArthur, Yusra AlSayyad ]
            yusra Yusra AlSayyad made changes -
            Attachment variance26_36738.png [ 36092 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Parejkoj John Parejko made changes -
            Reviewers Yusra AlSayyad [ yusra ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Parejkoj John Parejko made changes -
            Sprint AP S19-1 [ 825 ]
            Labels SciencePipelines
            Priority Undefined [ 10000 ] Major [ 3 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-16596 [ DM-16596 ]
            yusra Yusra AlSayyad made changes -
            Attachment varianceEvolution9697Y26.png [ 36396 ]
            yusra Yusra AlSayyad made changes -
            swinbank John Swinbank made changes -
            Epic Link DM-10153 [ 31778 ]
            swinbank John Swinbank made changes -
            Story Points 2
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            yusra Yusra AlSayyad made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.