Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16650

Use nJy in PhotoCalib as the unit for calibrated fluxes

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Templates:
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      AP S19-1
    • Team:
      Alert Production

      Description

      This implements RFC-549.  To my knowledge, PhotoCalib is currently the only part of the codebase that uses any unit for calibrated fluxes right now.  Please comment here if you know of any other code.

        Attachments

          Issue Links

          contains

          Bug - A problem which impairs or prevents the functions of the product. DM-16696 PhotoCalib produces negative flux errors for negative flux measurements.

          • Done
          duplicates

          Bug - A problem which impairs or prevents the functions of the product. DM-16696 PhotoCalib produces negative flux errors for negative flux measurements.

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-549 Use nanojansky for calibrated fluxes in DM code and intermediate data products

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16830 Add versioning to PhotoCalib

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17029 Update LoadReferenceObjectsTask to output fluxes in nanojansky

          • Done

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for your help with the review, Eli Rykoff! I posted in slack#dm-jointcal at the end of last week about the upcoming merge.

            Here is the Community post summarizing these changes: https://community.lsst.org/t/photocalib-is-now-defined-in-terms-of-nanojansky/3508

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for your help with the review, Eli Rykoff ! I posted in slack#dm-jointcal at the end of last week about the upcoming merge. Here is the Community post summarizing these changes: https://community.lsst.org/t/photocalib-is-now-defined-in-terms-of-nanojansky/3508 Merged and done.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            New post-review jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29187/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited New post-review jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29187/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            New Jenkins run with fix for abs: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29142/pipeline

            Show
            Parejkoj John Parejko added a comment - New Jenkins run with fix for abs : https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29142/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            lsst.afw.image.fluxFromABMag() will be going away with Calib, so I'm not too worried about it (especially since it doesn't tell you what units come out of it).

            Show
            Parejkoj John Parejko added a comment - lsst.afw.image.fluxFromABMag() will be going away with Calib , so I'm not too worried about it (especially since it doesn't tell you what units come out of it).
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            There's still the issue that right now one can call (from python) lsst.afw.image.fluxFromABMag() and this is something different from lsst::utils::ABMagnitudeToNanojansky() (though I guess this isn't exposed in Python by this name). The fact that this first call is actually part of Calib rather than PhotoCalib is not apparent to the user (for example me, until now) at all.

            Show
            erykoff Eli Rykoff added a comment - There's still the issue that right now one can call (from python) lsst.afw.image.fluxFromABMag() and this is something different from lsst::utils::ABMagnitudeToNanojansky() (though I guess this isn't exposed in Python by this name). The fact that this first call is actually part of Calib rather than PhotoCalib is not apparent to the user (for example me, until now) at all.
            8 older comments

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, Michael Wood-Vasey [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.