Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16650

Use nJy in PhotoCalib as the unit for calibrated fluxes

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None

    Description

      This implements RFC-549.  To my knowledge, PhotoCalib is currently the only part of the codebase that uses any unit for calibrated fluxes right now.  Please comment here if you know of any other code.

      Attachments

        Issue Links

          Activity

            erykoff Eli Rykoff added a comment -

            There's still the issue that right now one can call (from python) lsst.afw.image.fluxFromABMag() and this is something different from lsst::utils::ABMagnitudeToNanojansky() (though I guess this isn't exposed in Python by this name). The fact that this first call is actually part of Calib rather than PhotoCalib is not apparent to the user (for example me, until now) at all.

            erykoff Eli Rykoff added a comment - There's still the issue that right now one can call (from python) lsst.afw.image.fluxFromABMag() and this is something different from lsst::utils::ABMagnitudeToNanojansky() (though I guess this isn't exposed in Python by this name). The fact that this first call is actually part of Calib rather than PhotoCalib is not apparent to the user (for example me, until now) at all.
            Parejkoj John Parejko added a comment -

            lsst.afw.image.fluxFromABMag() will be going away with Calib, so I'm not too worried about it (especially since it doesn't tell you what units come out of it).

            Parejkoj John Parejko added a comment - lsst.afw.image.fluxFromABMag() will be going away with Calib , so I'm not too worried about it (especially since it doesn't tell you what units come out of it).
            Parejkoj John Parejko added a comment - New Jenkins run with fix for abs : https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29142/pipeline
            Parejkoj John Parejko added a comment - - edited New post-review jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29187/pipeline
            Parejkoj John Parejko added a comment -

            Thanks for your help with the review, erykoff! I posted in slack#dm-jointcal at the end of last week about the upcoming merge.

            Here is the Community post summarizing these changes: https://community.lsst.org/t/photocalib-is-now-defined-in-terms-of-nanojansky/3508

            Merged and done.

            Parejkoj John Parejko added a comment - Thanks for your help with the review, erykoff ! I posted in slack#dm-jointcal at the end of last week about the upcoming merge. Here is the Community post summarizing these changes: https://community.lsst.org/t/photocalib-is-now-defined-in-terms-of-nanojansky/3508 Merged and done.

            People

              Parejkoj John Parejko
              jbosch Jim Bosch
              Eli Rykoff
              Eli Rykoff, Jim Bosch, John Parejko, Michael Wood-Vasey
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.