Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16668

Implement the UI for TAP service, Master Ticket

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • SUIT
    • 2
    • SUIT Sprint 2019-02, SUIT Sprint 2019-03, SUIT Sprint 2019-04, SUIT Sprint 2019-05
    • Science User Interface

    Description

      • UI should be 3-boxes layout. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constraints if the columns with the corresponding UCDs are present.
      • We need a widget for TableItemListField, (similar to but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and table lists. (Both of them can have long descriptions with links.)
      • We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy: tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
      • Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?

      Each of the items above can be a separate ticket.

      Other comments from prototype implementation https://github.com/Caltech-IPAC/firefly/pull/713:

      • ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
      • When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
      • Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
      • At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
      • The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.

      Attachments

        Issue Links

          Activity

            No builds found.
            xiuqin Xiuqin Wu [X] (Inactive) created issue -
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-8397 [ 28008 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue is blocked by DM-16666 [ DM-16666 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Labels FireflyCCB
            tatianag Tatiana Goldina made changes -
            Link This issue relates to DM-16707 [ DM-16707 ]
            tatianag Tatiana Goldina made changes -
            Watchers Xiuqin Wu [ Xiuqin Wu ] Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Trey Roby, Xiuqin Wu [ Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Trey Roby, Xiuqin Wu ]
            Description - UI should be 3-boxes layout we talked about in the meeting. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constrains if the columns with the corresponding UCDs are present.
            - We need a widget for TableItemListField, (similar to, but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and tables lists. (Both of them can have long descriptions with links.)
            - We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy. For example, tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
            - Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?
             
            Each of the items above can be a separate ticket.

            Other comments from prototype implementation https://github.com/Caltech-IPAC/firefly/pull/713:
            - ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
            - When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
            - Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
            - At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
            - The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.
            tatianag Tatiana Goldina made changes -
            Description - UI should be 3-boxes layout we talked about in the meeting. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constrains if the columns with the corresponding UCDs are present.
            - We need a widget for TableItemListField, (similar to, but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and tables lists. (Both of them can have long descriptions with links.)
            - We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy. For example, tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
            - Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?
             
            Each of the items above can be a separate ticket.

            Other comments from prototype implementation https://github.com/Caltech-IPAC/firefly/pull/713:
            - ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
            - When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
            - Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
            - At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
            - The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.
            - UI should be 3-boxes layout. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constrains if the columns with the corresponding UCDs are present.
            - We need a widget for TableItemListField, (similar to but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and table lists. (Both of them can have long descriptions with links.)
            - We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy: tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
            - Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?
             
            Each of the items above can be a separate ticket.

            Other comments from prototype implementation https://github.com/Caltech-IPAC/firefly/pull/713:
            - ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
            - When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
            - Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
            - At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
            - The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.
            roby Trey Roby made changes -
            Link This issue relates to DM-17217 [ DM-17217 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17211 [ DM-17211 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17213 [ DM-17213 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17216 [ DM-17216 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17214 [ DM-17214 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17212 [ DM-17212 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17215 [ DM-17215 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-17215 [ DM-17215 ]
            gpdf Gregory Dubois-Felsmann made changes -
            Description - UI should be 3-boxes layout. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constrains if the columns with the corresponding UCDs are present.
            - We need a widget for TableItemListField, (similar to but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and table lists. (Both of them can have long descriptions with links.)
            - We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy: tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
            - Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?
             
            Each of the items above can be a separate ticket.

            Other comments from prototype implementation https://github.com/Caltech-IPAC/firefly/pull/713:
            - ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
            - When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
            - Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
            - At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
            - The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.
            - UI should be 3-boxes layout. Left: selection of schema and table, bottom: columns with constraints, right: spatial/temporal/wavelength constraints if the columns with the corresponding UCDs are present.
             - We need a widget for TableItemListField, (similar to but hopefully more generic than IRSA's CatalogTableListField, which would map table rows into the selectable display items. This widget will be used to display schema and table lists. (Both of them can have long descriptions with links.)
             - We need to upgrade CatalogConstraintsPanel to take table model (rather than giving it processor id and parameters), so that we can pre-sort table model by column_index, if it is available, and use columns UCD information to display spatial/temporal/wavelength constraints. Also, as Loi pointed out, CatalogConstraintsPanel is buggy: tab should be moving the focus to the next input box, filters and selections should clear when different table is used. (There are some hard-to-reproduce edge cases, when they don't.)
             - Should we allow user to view and modify ADQL query? As shown by the prototype implementation, keeping ADQL and ADQL-building UI on the same page is tricky, because they have to be in sync, and while UI-to-ADQL is not hard, ADQL-to-UI is non-trivial. Should we allow free-form ADQL with tree-like schema browser on the side as an alternative to the table driven UI above?

            Each of the items above can be a separate ticket.

            Other comments from prototype implementation [https://github.com/Caltech-IPAC/firefly/pull/713:]
             - ADQL query is what get submitted, but it's not obvious that you need to click on Set ADQL from Constraints before Search.
             - When new schema and table are selected, ADQL query remained the previous value. Very confusing when you've gone through the selection/inputs process then click Search to get the same previous search results.
             - Having fixed boxes with spiny during loading may improve look and feel. As is, UI is resizing without feedback.
             - At some point, I assume there would not be both Additional constraints and ADQL Query in this dialog.
             - The native drop-down list box is not the best widget for displaying schema and table lists. We'll need one with multi-line formatting, similar to CatalogTableListField.
            tatianag Tatiana Goldina made changes -
            Link This issue relates to DM-17499 [ DM-17499 ]
            roby Trey Roby made changes -
            Labels FireflyCCB FireflyCCB TAP
            roby Trey Roby made changes -
            Link This issue relates to DM-17730 [ DM-17730 ]
            roby Trey Roby made changes -
            Summary Implement the UI for TAP service Implement the UI for TAP service, Master Ticket
            roby Trey Roby made changes -
            Link This issue relates to DM-18121 [ DM-18121 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-18122 [ DM-18122 ]
            roby Trey Roby made changes -
            Link This issue relates to DM-18123 [ DM-18123 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-02 [ 815 ] SUIT Sprint 2019-02, SUIT Sprint 2019-3 [ 815, 860 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 20 2
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-02, SUIT Sprint 2019-03 [ 815, 860 ] SUIT Sprint 2019-02, SUIT Sprint 2019-03, SUIT Sprint 2019-04 [ 815, 860, 861 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue relates to DM-18690 [ DM-18690 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue relates to DM-18692 [ DM-18692 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-02, SUIT Sprint 2019-03, SUIT Sprint 2019-04 [ 815, 860, 861 ] SUIT Sprint 2019-02, SUIT Sprint 2019-03, SUIT Sprint 2019-04, SUIT Sprint 2019-05 [ 815, 860, 861, 874 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Assignee Xiuqin Wu [ xiuqin ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]

            The tracking purpose of this ticket is fulfilled. 

            xiuqin Xiuqin Wu [X] (Inactive) added a comment - The tracking purpose of this ticket is fulfilled. 
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]

            People

              xiuqin Xiuqin Wu [X] (Inactive)
              xiuqin Xiuqin Wu [X] (Inactive)
              Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.