# PhotoCalib produces negative flux errors for negative flux measurements.

XMLWordPrintable

#### Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
1
• Sprint:
AP S19-1
• Team:

#### Description

The PhotoCalib, instFluxToMaggies method is missing an absolute value causing calibrated flux errors to be negative when fluxes are negative (as can happen in a difference image).

#### Activity

No builds found.
Chris Morrison [X] (Inactive) created issue -
John Parejko made changes -
Field Original Value New Value
Watchers Chris Morrison [ Chris Morrison ] Chris Morrison, Eric Bellm, Jim Bosch, John Swinbank [ Chris Morrison, Eric Bellm, Jim Bosch, John Swinbank ]
John Parejko made changes -
 Priority Undefined [ 10000 ] Critical [ 2 ]
John Parejko made changes -
 Issue Type Story [ 10001 ] Bug [ 1 ]
Hide
John Parejko added a comment -

Also, as part of this I should refactor the flux error calculation to take out the division by instFlux, so we don't get NaN flux for 0 counts.

Show
John Parejko added a comment - Also, as part of this I should refactor the flux error calculation to take out the division by instFlux , so we don't get NaN flux for 0 counts.
John Parejko made changes -
 Summary PhotoCalib produces negitive flux errors for negative flux measurements. PhotoCalib produces negative flux errors for negative flux measurements.
Hide
John Parejko added a comment -

I'm going to do this as part of DM-16650, which is going on now.

Show
John Parejko added a comment - I'm going to do this as part of DM-16650 , which is going on now.
John Parejko made changes -
 Status To Do [ 10001 ] In Progress [ 3 ]
John Parejko made changes -
 Link This issue is contained by DM-16650 [ DM-16650 ]
John Parejko made changes -
 Sprint AP S19-1 [ 825 ]
John Swinbank made changes -
 Link This issue is duplicated by DM-16650 [ DM-16650 ]
Hide
John Swinbank added a comment -

“Won't Fix“-ing as a duplicate of DM-16650, which isn't quite true (this is a subset, rather than a duplicate), but it'll do.

Show
John Swinbank added a comment - “Won't Fix“-ing as a duplicate of DM-16650 , which isn't quite true (this is a subset, rather than a duplicate), but it'll do.
John Swinbank made changes -
 Resolution Done [ 10000 ] Status In Progress [ 3 ] Won't Fix [ 10405 ]
Hide
John Parejko added a comment -

This is definitely not "won't fix": it's been done as part of DM-16650 (not a duplicate, it was just logical to do the work there), and will be marked "done" when that ticket is merged.

Show
John Parejko added a comment - This is definitely not "won't fix": it's been done as part of DM-16650 (not a duplicate, it was just logical to do the work there), and will be marked "done" when that ticket is merged.
John Parejko made changes -
 Resolution Done [ 10000 ] Status Won't Fix [ 10405 ] In Progress [ 3 ]
Hide
John Parejko added a comment -

DM-16650 was merged, and thus this fix is now in place (with an updated unittest to check for it).

Show
John Parejko added a comment - DM-16650 was merged, and thus this fix is now in place (with an updated unittest to check for it).
John Parejko made changes -
 Resolution Done [ 10000 ] Status In Progress [ 3 ] Done [ 10002 ]
John Swinbank made changes -
 Epic Link DM-16722 [ 235355 ]
John Swinbank made changes -
 Epic Link DM-16722 [ 235355 ] DM-10153 [ 31778 ]

#### People

Assignee:
John Parejko
Reporter:
Chris Morrison [X] (Inactive)
Watchers:
Chris Morrison [X] (Inactive), Eric Bellm, Jim Bosch, John Parejko, John Swinbank