Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16702

Add reference stars to fgcmcal fit as an option

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      12
    • Epic Link:
    • Sprint:
      DRP S19-3, DRP S19-4, DRP S19-5, DRP S19-6a, DRP S19-6b
    • Team:
      Data Release Production

      Description

      Currently, fgcm runs without any reference stars for the fit, solving everything internally for a relative calibration.  Reference stars can be loaded to create an absolute calibration for the final output.

      For the new "fgcmcal-tract" mode, we need to be able to use reference stars in the fit.  We will also be able to use these reference stars for absolute calibration in the case that a small number of calspec/WD stars with known SEDs are available.

      This ticket will add the ability to use reference stars in the fit, and allow additional absolute calibration terms.

        Attachments

          Issue Links

            Activity

            Hide
            erykoff Eli Rykoff added a comment -

            The lsst/fgcm code is from the third-party repo, and does not technically need a review. (Also note that this is to be merged into the lsst-dev branch). The bulk of the review is on lsst/fgcmcal.

            Show
            erykoff Eli Rykoff added a comment - The lsst/fgcm code is from the third-party repo, and does not technically need a review. (Also note that this is to be merged into the lsst-dev branch). The bulk of the review is on lsst/fgcmcal .
            Hide
            yusra Yusra AlSayyad added a comment -

            Really great documentation throughout!!

            Didn't see anything major. I made comments with minor reactions as I read through it in github.

            Disappointed to find that parsAndRun-in-unittest anti-pattern copied from JointcalTestBase. parseAndRun() goes away in Novemeber, so we'll take a look at refactoring those unit tests later.

            Show
            yusra Yusra AlSayyad added a comment - Really great documentation throughout!! Didn't see anything major. I made comments with minor reactions as I read through it in github. Disappointed to find that parsAndRun-in-unittest anti-pattern copied from JointcalTestBase. parseAndRun() goes away in Novemeber, so we'll take a look at refactoring those unit tests later.

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Eli Rykoff, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: