Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16704

Add fgcmcal-tract mode to fgcmcal for small-scale processing with a reference catalog

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: fgcmcal
    • Labels:
      None

      Description

      This ticket will add the fgcmcal-tract mode to fgcmcal to allow small-scale processing of a single tract.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20161 Run tract-based fgcmcal on RC2 dataset

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17305 Automate selection of "non-photometric" cuts for fgcmcal runs

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21052 Update the pipe_analysis scripts to have the option to apply fgcm calibrations

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            PRs are here: https://github.com/lsst/obs_base/pull/167 https://github.com/lsst/obs_subaru/pull/220 https://github.com/lsst/fgcmcal/pull/16
            Jenkins here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30334/pipeline

            Show
            erykoff Eli Rykoff added a comment - PRs are here: https://github.com/lsst/obs_base/pull/167 https://github.com/lsst/obs_subaru/pull/220 https://github.com/lsst/fgcmcal/pull/16 Jenkins here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30334/pipeline
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Looks good. I left a number of comments on the fgcmcal pull request, mostly about the documentation.

             

            Show
            sullivan Ian Sullivan added a comment - Looks good. I left a number of comments on the fgcmcal pull request, mostly about the documentation.  
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Ian Sullivan Thanks for your quick review. One of your comments made me realize that my logic on selecting which dataRefs to run on was flawed, and I did an overhaul (that also removes a bunch of code, yay!). If you could take another look at fgcmBuildStars.py, in particular findAndGroupDataRefs (https://github.com/lsst/fgcmcal/blob/245f2b3ebd5cad4995dd20152b24b373f79d51d4/python/lsst/fgcmcal/fgcmBuildStars.py#L457) that would be very helpful.

            Show
            erykoff Eli Rykoff added a comment - Ian Sullivan Thanks for your quick review. One of your comments made me realize that my logic on selecting which dataRefs to run on was flawed, and I did an overhaul (that also removes a bunch of code, yay!). If you could take another look at fgcmBuildStars.py , in particular findAndGroupDataRefs ( https://github.com/lsst/fgcmcal/blob/245f2b3ebd5cad4995dd20152b24b373f79d51d4/python/lsst/fgcmcal/fgcmBuildStars.py#L457 ) that would be very helpful.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Final (successful) Jenkins run here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30363/pipeline

            Show
            erykoff Eli Rykoff added a comment - Final (successful) Jenkins run here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30363/pipeline

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Ian Sullivan
              Watchers:
              Eli Rykoff, Ian Sullivan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: