Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16736

Let MetricsControllerTask store application-specific metadata

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: verify
    • Labels:
      None

      Description

      As originally designed, lsst.verify.compatibility.MetricsControllerTask can store only metadata that is required (e.g., by SQuaSH) for all metrics. However, applications like ap_verify, validate_drp, etc. may wish to store information that's specific to their workflow.

      Design and implement a system for passing generic Job-level metadata to MetricsControllerTask.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-16642 Generalize job metadata code

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Proposed API: add an optional argument to MetricsControllerTask.runDataRef that takes a dictionary of metadata keys and values. This is more work for the client than registering metadata once with the class, but it's more flexible. Given that the SQuaSH-required metadata (specifically, the data ID) is already different for different runs, it's reasonable to support run-specific values for application-specific metadata as well.

            Show
            krzys Krzysztof Findeisen added a comment - Proposed API: add an optional argument to MetricsControllerTask.runDataRef that takes a dictionary of metadata keys and values. This is more work for the client than registering metadata once with the class, but it's more flexible. Given that the SQuaSH-required metadata (specifically, the data ID) is already different for different runs, it's reasonable to support run-specific values for application-specific metadata as well.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Hi Eric Bellm, can you take a look at this 20-line change? Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Hi Eric Bellm , can you take a look at this 20-line change? Thanks!
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Looks good!

            Show
            ebellm Eric Bellm added a comment - Looks good!

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Eric Bellm
              Watchers:
              Eric Bellm, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.