Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16736

Let MetricsControllerTask store application-specific metadata

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: verify
    • Labels:
      None

      Description

      As originally designed, lsst.verify.compatibility.MetricsControllerTask can store only metadata that is required (e.g., by SQuaSH) for all metrics. However, applications like ap_verify, validate_drp, etc. may wish to store information that's specific to their workflow.

      Design and implement a system for passing generic Job-level metadata to MetricsControllerTask.

        Attachments

          Issue Links

            Activity

            krzys Krzysztof Findeisen created issue -
            krzys Krzysztof Findeisen made changes -
            Field Original Value New Value
            Link This issue relates to DM-16642 [ DM-16642 ]
            krzys Krzysztof Findeisen made changes -
            Epic Link DM-16713 [ 235321 ]
            krzys Krzysztof Findeisen made changes -
            Rank Ranked higher
            krzys Krzysztof Findeisen made changes -
            Sprint AP S19-4 [ 832 ]
            krzys Krzysztof Findeisen made changes -
            Rank Ranked lower
            krzys Krzysztof Findeisen made changes -
            Sprint AP S19-4 [ 832 ] AP S19-5 [ 833 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16713 [ 235321 ] DM-17992 [ 240548 ]
            swinbank John Swinbank made changes -
            Epic Link DM-17992 [ 240548 ] DM-17980 [ 240508 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-5 [ 833 ] AP S19-5, AP S19-6 [ 833, 834 ]
            Hide
            krzys Krzysztof Findeisen added a comment -

            Proposed API: add an optional argument to MetricsControllerTask.runDataRef that takes a dictionary of metadata keys and values. This is more work for the client than registering metadata once with the class, but it's more flexible. Given that the SQuaSH-required metadata (specifically, the data ID) is already different for different runs, it's reasonable to support run-specific values for application-specific metadata as well.

            Show
            krzys Krzysztof Findeisen added a comment - Proposed API: add an optional argument to MetricsControllerTask.runDataRef that takes a dictionary of metadata keys and values. This is more work for the client than registering metadata once with the class, but it's more flexible. Given that the SQuaSH-required metadata (specifically, the data ID) is already different for different runs, it's reasonable to support run-specific values for application-specific metadata as well.
            krzys Krzysztof Findeisen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            krzys Krzysztof Findeisen made changes -
            Status In Progress [ 3 ] To Do [ 10001 ]
            krzys Krzysztof Findeisen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Eric Bellm, can you take a look at this 20-line change? Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Hi Eric Bellm , can you take a look at this 20-line change? Thanks!
            krzys Krzysztof Findeisen made changes -
            Reviewers Eric Bellm [ ebellm ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            ebellm Eric Bellm added a comment -

            Looks good!

            Show
            ebellm Eric Bellm added a comment - Looks good!
            ebellm Eric Bellm made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krzys Krzysztof Findeisen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Eric Bellm
              Watchers:
              Eric Bellm, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: