Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:10
-
Epic Link:
-
Sprint:SUIT Sprint 2018-12, SUIT Sprint 2019-01
-
Team:Science User Interface
Description
Do the following:
- Update display_firefly to work with the firefly_client updates for Jupyter lab
- Update the Pip install of firefly_client
- Update firefly_client fork on the lsst side
- Test the whole think so that it is working together correctly
Attachments
Issue Links
Activity
After some discussion with Trey Roby, I am moving this back to In Progress to add on some changes we want to make in `firefly_client`.
David Shupe
added a comment - After some discussion with Trey Roby , I am moving this back to In Progress to add on some changes we want to make in `firefly_client`. The pull request for firefly_client was reviewed by Trey Roby on Github.
Cindy Wang [X] reviewed the display_firefly PR on Github.
David Shupe
added a comment - The pull request for firefly_client was reviewed by Trey Roby on Github.
Cindy Wang [X] reviewed the display_firefly PR on Github. As part of this work, the firefly_client 2.1.0 release is now available via pip install. This version has been synced to the lsst fork.
David Shupe
added a comment - - edited As part of this work, the firefly_client 2.1.0 release is now available via pip install . This version has been synced to the lsst fork. In the course of testing the daily lsst_d_2019_01_25 containing the merges of the two main PRs for this ticket, a minor bug was found that does not allow the user to override url when using the vanilla make_client factory function. A simple copy-and-paste error is the cause and a postfix PR is added for firefly_client.
Default usage in the science platforms is not affected by this bug; nor is usage with the Jupyterlab Firefly extension; nor whenever the environment variable FIREFLY_URL is set.
David Shupe
added a comment - In the course of testing the daily lsst_d_2019_01_25 containing the merges of the two main PRs for this ticket, a minor bug was found that does not allow the user to override url when using the vanilla make_client factory function. A simple copy-and-paste error is the cause and a postfix PR is added for firefly_client .
Default usage in the science platforms is not affected by this bug; nor is usage with the Jupyterlab Firefly extension; nor whenever the environment variable FIREFLY_URL is set. Bugfix completed. Version 2.1.1 of firefly_client is release on PyPI and has been synced to the lsst fork. It will appear in weekly lsst_w_2019_4.
David Shupe
added a comment - Bugfix completed. Version 2.1.1 of firefly_client is release on PyPI and has been synced to the lsst fork. It will appear in weekly lsst_w_2019_4 . 
I have tested in lsst-lspdev where there is no extension, and in a local Docker container with the extension.
The user guide text was in the wrong place – I moved it and made some slight updates. Not sure if we should talk about the Jupyter extension now, might be better to wait to add that to the doc.