Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16803

Refactor ci_hsc build scripts for better Gen3 testing

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc
    • Labels:

      Description

      It's currently a pain to write any tests for successful Gen2->Gen3 conversion or PipelineTask execution in ci_hsc beyond just testing that the code ran through to completion.  That's currently a blocker for the tests I would have liked to add on DM-15503.

      Rewriting the ci_hsc SConstruct to separate the data IDs from the execution script and make the validation tests regular unit tests should solve both of those problems.

      This is a potentially open-ended problem; shouldn't spend more than a day actually working on it, as we don't need to make it perfect.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Epic Link DM-16675 [ 235235 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-15503 [ DM-15503 ]
            Hide
            jbosch Jim Bosch added a comment -

            I started in on this (branch tickets/DM-16803 of ci_hsc) but ran into a bit of a wall.   I'm no longer convinced this is worth doing before we have all of the CmdLineTasks here available in {PipelineTask form; we'll just have to limp along with one-off tests until that's done.

             

            Show
            jbosch Jim Bosch added a comment - I started in on this (branch tickets/ DM-16803 of ci_hsc) but ran into a bit of a wall.   I'm no longer convinced this is worth doing before we have all of the CmdLineTasks here available in {PipelineTask form; we'll just have to limp along with one-off tests until that's done.  
            yusra Yusra AlSayyad made changes -
            Epic Link DM-16675 [ 235235 ] DM-16771 [ 235477 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-16771 [ 235477 ] DM-20166 [ 323037 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-20166 [ 323037 ] DM-21254 [ 414685 ]
            Hide
            jbosch Jim Bosch added a comment -

            This is no longer relevant after this split into ci_hsc_gen2 and ci_hsc_gen3.

            Show
            jbosch Jim Bosch added a comment - This is no longer relevant after this split into ci_hsc_gen2 and ci_hsc_gen3.
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Won't Fix [ 10405 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.