Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Team:Data Release Production
Description
Lauren MacArthur reports that if doCrosstalk is set to True, rather than raising like all other parts of isr (right?!) when failing to find the necessary calibration products, processing continues, and sets all xtalk bits in the mask plane.
Fix should be to raise if parameters aren't found, in keeping with doBias, doFlat, etc.
Attachments
Activity
Thank you Lauren. I remember that the list included "lsst_distrib lsst_ci" but not "ci_hsc". I will run jenkins again.
Andrés Alejandro Plazas Malagón — did you get your git issues resolved? If not, ping me and I'll walk through it with you.
John Swinbank: thank you! Before leaving for the break, Lauren and Chris came to my office and helped me. I'm going to try again and I will let you know if I run into problems.
I'm still happy with these changes, even after restricting the "raise" to just `crosstalk.py`. The commits should probably be squashed, and the `isrTask.py` change isn't needed anymore, but those aren't big issues.
ci_hsc runs some basic pipeline tasks on a small set of HSC data to make sure changes don't break actual running of the tasks (and catching issues that may be missed by the unittests). You add ci_hsc to the list of PRODUCTS in jenkins, so your list should look like:
PRODUCTS lsst_distrib lsst_ci ci_hsc