Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16819

Make minimal Gen3 shim for Gen2 DataRef, ButlerSubset, and Butler

    XMLWordPrintable

    Details

      Description

      Write minimal shims that implement some Gen2 APIs using Gen3 implementations.  That will start with just get and put on DataRef and Butler, for Tasks that (at most) just pass Data IDs around without looking at what's in them.

      Future ticket could add some data ID translation, if we decide that's better than putting conditional logic in the Tasks themselves.

      Also add a "gen" attribute to both Butler classes, so conditional code can actually be written.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16876 Revisit Butler ctor keyword argument names

          • Won't Fix

            Activity

            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            This is just about ready for review.  I'm still working on the tests in ci_hsc - the test script passes when run manually, but it turns out the weird SConstruct doesn't even run the previous test script there.  Anyhow, changes are in:

            New functionality includes the shim classes themselves (in pipe_base), some class attributes for generation-specific logic in Tasks in daf_butler and daf_persistence, and some otherwise-unrelated fixes to raw data reading that I discovered while working on the tests.

            While I've asked Nate Lust to review, Yusra AlSayyad and Christopher Waters might want to have a look at the pipe_base changes as well.

             

            Show
            jbosch Jim Bosch added a comment - This is just about ready for review.  I'm still working on the tests in ci_hsc - the test script passes when run manually, but it turns out the weird SConstruct doesn't even run the previous test script there.  Anyhow, changes are in: https://github.com/lsst/daf_butler/pull/110 https://github.com/lsst/daf_persistence/pull/106 https://github.com/lsst/pipe_base/pull/70 https://github.com/lsst/obs_subaru/pull/170 https://github.com/lsst/ci_hsc/pull/66 New functionality includes the shim classes themselves (in pipe_base), some class attributes for generation-specific logic in Tasks in daf_butler and daf_persistence, and some otherwise-unrelated fixes to raw data reading that I discovered while working on the tests. While I've asked Nate Lust to review, Yusra AlSayyad and Christopher Waters might want to have a look at the pipe_base changes as well.  

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, Nate Lust, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.