Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16855

Convert afw.cameraGeom to numpydoc

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S19-1, AP S19-2
    • Team:
      Alert Production

      Description

      Convert all Doxygen-formatted docstrings in afw.cameraGeom to Numpydoc style, and move corresponding topic documentation to doc/.

        Attachments

          Activity

          Descending order - Click to sort in ascending order
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Merged and done.

          Show
          Parejkoj John Parejko added a comment - Merged and done.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Thanks for the review!

          New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29251/pipeline

          Show
          Parejkoj John Parejko added a comment - Thanks for the review! New Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29251/pipeline
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Looks great! Just a few small requested changes on github (most notably, please make the class names links in the new .rst file)

          Show
          rowen Russell Owen added a comment - Looks great! Just a few small requested changes on github (most notably, please make the class names links in the new .rst file)
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Russell Owen: I've cleaned up per your comments and converted the `cameraGeom.dox` file to .rst and fixed its links. Anything else?

          Show
          Parejkoj John Parejko added a comment - Russell Owen : I've cleaned up per your comments and converted the `cameraGeom.dox` file to .rst and fixed its links. Anything else?
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Pull request: https://github.com/lsst/afw/pull/426

          I took a first pass and requested some changes.

          Show
          rowen Russell Owen added a comment - - edited Pull request: https://github.com/lsst/afw/pull/426 I took a first pass and requested some changes.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Russell Owen: Thanks for volunteering.

          The commits are atomic; you probably want to look at them separately.

          Show
          Parejkoj John Parejko added a comment - Russell Owen : Thanks for volunteering. The commits are atomic; you probably want to look at them separately.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29185/pipeline

          Show
          Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29185/pipeline

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            krzys Krzysztof Findeisen
            Reviewers:
            Russell Owen
            Watchers:
            John Parejko, Krzysztof Findeisen, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.