Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16867

Split pipe_supertask into two other packages

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      BG3_F18_11
    • Team:
      Data Access and Database

      Description

      Implementing RFC-554, there will be a lot of renaming but some code needs dependency cleanup and API change.

      This ticket covers moving modules from pipe_supertask into pipe_base and new package ctrl_mpexec. Further re-factoring of ctrl_mpexec contents will be done on a separate ticket.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-554 Refactoring of pipe_supertask

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Re-opening this for now, will split pipe_supertask into three rather than two packages - all expr_praser stuff will be moved to daf_butler.

            Show
            salnikov Andy Salnikov added a comment - Re-opening this for now, will split pipe_supertask into three rather than two packages - all expr_praser stuff will be moved to daf_butler .
            Hide
            Permalink
            salnikov Andy Salnikov added a comment - - edited

            Few small changes since last approval:

            • dropped support for instrument override in its current form (it was not implemented), PipelineBuilder method removed one optional argument, and pipetask dropped one command line argument (commit 9a318c0 in ctrl_mpexec for latter)
            • expr_parser code was moved to daf_butler and renamed to epxrParser (this is already approved though before renaming to exprParser)

            There is not much to look at, maybe 9a318c0 in ctrl_mpexec is the only interesting change.

            Show
            salnikov Andy Salnikov added a comment - - edited Few small changes since last approval: dropped support for instrument override in its current form (it was not implemented), PipelineBuilder method removed one optional argument, and pipetask dropped one command line argument (commit 9a318c0 in ctrl_mpexec for latter) expr_parser code was moved to daf_butler and renamed to epxrParser (this is already approved though before renaming to exprParser) There is not much to look at, maybe 9a318c0 in ctrl_mpexec is the only interesting change.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Reapproved!

            Show
            jbosch Jim Bosch added a comment - Reapproved!
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Thanks for review and all suggestions! Jenkins build of the branch was OK, so I merged all three packages.

            I just realized that there is an open pull request on pipe_supertask (DM-16797). Nate Lust, can this be re-applied to new packages instead?

            I think it would be better to make pipe_supertask read-only now to avoid confusion, have to find someone who can do it.

            Show
            salnikov Andy Salnikov added a comment - Thanks for review and all suggestions! Jenkins build of the branch was OK, so I merged all three packages. I just realized that there is an open pull request on pipe_supertask ( DM-16797 ).  Nate Lust , can this be re-applied to new packages instead? I think it would be better to make pipe_supertask read-only now to avoid confusion, have to find someone who can do it.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Andy Salnikov, I could have sworn that got merged in already, I closed that ticket over the holiday. I probably forgot to push master to github or something. Yes that work should just transfer over, I will look at doing that this morning after our group meeting.

            Show
            nlust Nate Lust added a comment - Andy Salnikov , I could have sworn that got merged in already, I closed that ticket over the holiday. I probably forgot to push master to github or something. Yes that work should just transfer over, I will look at doing that this morning after our group meeting.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Jim Bosch
              Watchers:
              Andy Salnikov, Jim Bosch, Nate Lust, Vaikunth Thukral
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.