Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1688

CSS version must be defined only once

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Team:
      Data Access and Database

      Description

      For now Qserv CSS version is defined 3 times, this is not good:

      core/modules/css/constants.h:char const VERSION[] = "1"; ///< Current supported version
      		 
      core/modules/css/Facade.cc:// NOTE: THIS NUMBER MUST MATCH VERSION DEFINED IN qservAdmin.py.
      		 
      core/modules/css/Facade.cc:const int VERSION = 1;
      		 
      core/modules/css/Facade.cc:const std::string VERSION_STR = boost::lexical_cast<std::string>(VERSION);
      		 
      qserv@clrinfoport09:~/src/qserv (u/fjammes/DM-627 *) $ grep -rw VERSION admin/python/
      		 
      admin/python/lsst/qserv/admin/qservAdmin.py:# NOTE: THIS NUMBER MUST MATCH VERSION DEFINED IN CSS/FACADE.
      		 
      admin/python/lsst/qserv/admin/qservAdmin.py:VERSION = 1

        Attachments

          Issue Links

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Fritz Mueller is this still a problem?

            Show
            tjenness Tim Jenness added a comment - Fritz Mueller is this still a problem?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Fritz Mueller is this still a problem?

            Show
            tjenness Tim Jenness added a comment - Fritz Mueller is this still a problem?
            Hide
            Permalink
            jammes Fabrice Jammes added a comment -

            Tim Jenness, this has been fixed in another ticket.

            Show
            jammes Fabrice Jammes added a comment - Tim Jenness , this has been fixed in another ticket.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Probably DM-3574 then.

            Show
            tjenness Tim Jenness added a comment - Probably DM-3574 then.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jammes Fabrice Jammes
              Watchers:
              Andy Salnikov, Daniel Wang [X] (Inactive), Fabrice Jammes, Jacek Becla, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.