Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-16925

Provide backwards-compatibility with Calib API

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 8
    • AP S19-2, AP S19-3, AP S19-4, AP S19-5
    • Alert Production

    Description

      Where possible, add a (deprecated, following the procedure in RFC-557 unless that RFC has been rejected by the time you get to this) backwards compatible API to PhotoCalib to enable it to act as a drop-in replacement for Calib.

      Per discussion of 2018-12-19, the most important goal here is to provide conversion to/from magnitudes using the same API as Calib uses, but, in general, the aim of this ticket is to minimize avoidable disruption to “science users” when PhotoCalib replaces Calib, without imposting an unmanageable development load. (To meet the latter goal, I suggest timeboxing initial work on this to no more than a week or so before sending for review.)

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment -

            These code changes look great. I posted a few small suggestions on the PR. My only substantive concern is that the new setThrowOnNegativeFlux silently ignores true.

            rowen Russell Owen added a comment - These code changes look great. I posted a few small suggestions on the PR. My only substantive concern is that the new setThrowOnNegativeFlux silently ignores true.
            Parejkoj John Parejko added a comment - New post review, post rebase Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29592/pipeline
            Parejkoj John Parejko added a comment -

            I merged this earlier today before noticing that sophiereed had not signed off. However, this will probably make testing easier, since I can just rebase DM-10156 on top of this and then you can use just that ticket to do your backwards compatibility testing.

            Parejkoj John Parejko added a comment - I merged this earlier today before noticing that sophiereed had not signed off. However, this will probably make testing easier, since I can just rebase DM-10156 on top of this and then you can use just that ticket to do your backwards compatibility testing.
            Parejkoj John Parejko added a comment -

            I've pushed an attempted fix for meas_mosaic (handling the refcat colorterms better): can you please test it?

            Parejkoj John Parejko added a comment - I've pushed an attempted fix for meas_mosaic (handling the refcat colorterms better): can you please test it?
            Parejkoj John Parejko added a comment -

            Merged and done

            Parejkoj John Parejko added a comment - Merged and done

            People

              Parejkoj John Parejko
              swinbank John Swinbank
              Sophie Reed
              Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Russell Owen, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.