Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17028

Write PipelineTask to Make Warps (MakeCoaddTempExp conversion)

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          yusra Yusra AlSayyad added a comment - - edited

          The command to test this
          {{pipetask -b /project/yusra/ci_hsc/DATA/butler.yaml
          -i shared/ci_hsc -o test/warp -d "Tract.tract=0 and Patch.patch=69 and Visit.visit=903986" run -t makeCoaddTempExp.MakeWarpTask --configfile MakeWarpTask:makeWarpTask.py}}

          I don't like the makeCoaddTempExp.MakeWarpTask part. And it makes me want to start the new makeWarp.py module. How awful would it be to have a makeCoaddTempExp.py and a makeWarp.py living side by side?

          Show
          yusra Yusra AlSayyad added a comment - - edited The command to test this {{pipetask -b /project/yusra/ci_hsc/DATA/butler.yaml -i shared/ci_hsc -o test/warp -d "Tract.tract=0 and Patch.patch=69 and Visit.visit=903986" run -t makeCoaddTempExp.MakeWarpTask --configfile MakeWarpTask:makeWarpTask.py}} I don't like the makeCoaddTempExp.MakeWarpTask part. And it makes me want to start the new makeWarp.py module. How awful would it be to have a makeCoaddTempExp.py and a makeWarp.py living side by side?
          Hide
          jbosch Jim Bosch added a comment -

          How awful would it be to have a makeCoaddTempExp.py and a makeWarp.py living side by side?

          Not bad at all, IMO.  I tend to think (and I think the style guide agrees) that with the exception of obvious helper classes like configs, one-class-per-file should be the default and it's doing something else that needs to be motivated (though I'm also personally not very picky about said motivation).

          Show
          jbosch Jim Bosch added a comment - How awful would it be to have a makeCoaddTempExp.py and a makeWarp.py living side by side? Not bad at all, IMO.  I tend to think (and I think the style guide agrees) that with the exception of obvious helper classes like configs, one-class-per-file should be the default and it's doing something else that needs to be motivated (though I'm also personally not very picky about said motivation).
          Hide
          jbosch Jim Bosch added a comment -

          I assume the only relevant branches are in pipe_tasks and pipe_base?  If so, review complete!

          Show
          jbosch Jim Bosch added a comment - I assume the only relevant branches are in pipe_tasks and pipe_base?  If so, review complete!
          Hide
          yusra Yusra AlSayyad added a comment -

          Yes, and your commit on  pipe_base was already merged as part of DM-17045, so it's really just pipe_tasks.

           

          Show
          yusra Yusra AlSayyad added a comment - Yes, and your commit on  pipe_base was already merged as part of DM-17045 , so it's really just pipe_tasks.  
          Hide
          yusra Yusra AlSayyad added a comment -

          Merged into this weekly

          Show
          yusra Yusra AlSayyad added a comment - Merged into this weekly

            People

            • Assignee:
              yusra Yusra AlSayyad
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Jim Bosch, Nate Lust
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, Nate Lust, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: