Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17041

Make PipelineTask command-line label default to Task class name

    Details

    • Story Points:
      0.5
    • Sprint:
      BG3_F18_11
    • Team:
      Data Access and Database

      Description

      stac/pipetask currently require the user to create a label explicitly in order to provide config overrides. We should make the default label to the Task class name (i.e. the same name that was just passed to -t). While it's possible to to have multiple instances of the same Task, that's currently quite rare and we should make the common case simpler and more intuitive.

      After a bit of discussion, Nate Lust, Yusra AlSayyad, and I agreed it'd be better to use the Task class name rather than Task._defaultName because the former is what's also typically present on the same command line.

        Attachments

          Activity

          Hide
          nlust Nate Lust added a comment -

          I think I would prefer to have the colon, to have consistency with all the options on the command line. I can see some merit to using the name to be consistent with config files, but in that case I would request that if the user types things wrong like -t TASK -c TASK:option="hello world" that the activator report something other than tag not found, like TASK seems to be the name of a task, did you mean -c TAKS.option....". It may already do that I will confess I didn't know you could use it with a dot syntax.

          Show
          nlust Nate Lust added a comment - I think I would prefer to have the colon, to have consistency with all the options on the command line. I can see some merit to using the name to be consistent with config files, but in that case I would request that if the user types things wrong like -t TASK -c TASK:option="hello world" that the activator report something other than tag not found, like TASK seems to be the name of a task, did you mean -c TAKS.option....". It may already do that I will confess I didn't know you could use it with a dot syntax.
          Hide
          salnikov Andy Salnikov added a comment -

          OK, I'll switch to colon for -c option if that makes it less confusing.

          Show
          salnikov Andy Salnikov added a comment - OK, I'll switch to colon for -c option if that makes it less confusing.
          Hide
          salnikov Andy Salnikov added a comment -

          Trivial switch from dot to colon for consistency, this breaks compatibility but I presume there are not too many people using this yet.

          Show
          salnikov Andy Salnikov added a comment - Trivial switch from dot to colon for consistency, this breaks compatibility but I presume there are not too many people using this yet.
          Hide
          jbosch Jim Bosch added a comment -

          Looks good!

          Show
          jbosch Jim Bosch added a comment - Looks good!
          Hide
          salnikov Andy Salnikov added a comment -

          Thanks for review! Merged and done.

          Show
          salnikov Andy Salnikov added a comment - Thanks for review! Merged and done.

            People

            • Assignee:
              salnikov Andy Salnikov
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Andy Salnikov, Jim Bosch, Nate Lust
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel