Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_base
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:BG3_F18_11
-
Team:Data Access and Database
Description
Options like -c label.option=True don't seem to work. If needed, I think Yusra AlSayyad has a more complete how-to-reproduce.
Attachments
Activity
Nate Lust, as you have already worked on that code could you also review my changes to it? I added unit test with many option types so I'm more or less confident that it does what we need now.
I will look at this tonight or tomorrow morning
Nate Lust, thanks for reviewing and closing the ticket (though as a reviewer you are only required to mark it as Reviewed 
) I rebased and merged my branch, so it is indeed done now.
We do need better support for parsing values of the options on the command line (Nate has already started improving support for lists). One way to do it is just eval() the value (or safer ast.literal_eval()) but that is not super-convenient in all cases as one would need to quote regular strings. I think better option would be to check field dtype and only do eval if dtype is not str. I'll try to implement that to see if that can work.