Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17043

Add selection on S/N in objectSizeStarSelector

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      8
    • Sprint:
      DRP S19-1, DRP S19-2
    • Team:
      Data Release Production

      Description

      Currently, theĀ objectSizeStarSelector Task allows for source selection based on flux limits. A selection on signal-to-noise (S/N), i.e. flux/fluxErr, is often preferred, so should be added as an option for this source selector.

      Additionally, there is currently no unittest for objectSizeStarSelector, so a minimal one should be added (following the test_astrometrySourceSelector.py and test_matcherSourceSelector.py examples).

      For this ticket, the option will simply be added in the same manner as the flux selection is done, but all current defaults will be left as is. Looking towards the future, I anticipate submitting an RFC to make S/N selection the default (instead of a flux-based selection, but, in principle, both could be activated simultaneously) as well as adapting all the SourceSelectorTask to make use of the configuration-based selection classes in BaseSourceSelector-derived Tasks (e.g. objectSizeStarSelectorTask, AstrometrySourceSelectorTask, MatcherSourceSelectorTask, FlaggedSourceSelectorConfig) https://github.com/lsst/meas_algorithms/blob/master/python/lsst/meas/algorithms/sourceSelector.py#L153).

        Attachments

          Issue Links

            Activity

            lauren Lauren MacArthur created issue -
            lauren Lauren MacArthur made changes -
            Field Original Value New Value
            Epic Link DM-16678 [ 235238 ]
            lauren Lauren MacArthur made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            lauren Lauren MacArthur made changes -
            Description Currently, the *objectSizeStarSelector* Task allows for source selection based on flux limits. A selection on signal-to-noise (S/N), i.e. flux/fluxErr, is often preferred, so should be added as an option for this source selector.

            Additionally, there is currently no unittest for *objectSizeStarSelector*, so a minimal one should be added (following the *test_astrometrySourceSelector.py* and *test_matcherSourceSelector.py* examples).

            For this ticket, the option will simply be added in the same manner as the flux selection is done, but all current defaults will be left as is. Looking towards the future, I anticipate submitting an RFC to make S/N selection the default (instead of a flux-based selection, but, in principle, both could be activated simultaneously) as well as adapting all the *StarSelectorTask* to make use of the configuration-based selection classes in *BaseSourceSelector*-derived Tasks (e.g. *objectSizeStarSelectorTask*, *AstrometrySourceSelectorTask*, *MatcherSourceSelectorTask*, *FlaggedSourceSelectorConfig*) [https://github.com/lsst/meas_algorithms/blob/master/python/lsst/meas/algorithms/sourceSelector.py#L153]).
            Currently, the *objectSizeStarSelector* Task allows for source selection based on flux limits. A selection on signal-to-noise (S/N), i.e. flux/fluxErr, is often preferred, so should be added as an option for this source selector.

            Additionally, there is currently no unittest for *objectSizeStarSelector*, so a minimal one should be added (following the *test_astrometrySourceSelector.py* and *test_matcherSourceSelector.py* examples).

            For this ticket, the option will simply be added in the same manner as the flux selection is done, but all current defaults will be left as is. Looking towards the future, I anticipate submitting an RFC to make S/N selection the default (instead of a flux-based selection, but, in principle, both could be activated simultaneously) as well as adapting all the *SourceSelectorTask* to make use of the configuration-based selection classes in *BaseSourceSelector*-derived Tasks (e.g. *objectSizeStarSelectorTask*, *AstrometrySourceSelectorTask*, *MatcherSourceSelectorTask*, *FlaggedSourceSelectorConfig*) [https://github.com/lsst/meas_algorithms/blob/master/python/lsst/meas/algorithms/sourceSelector.py#L153]).
            lauren Lauren MacArthur made changes -
            Attachment plot-v1228-base_PsfFlux-hist.png [ 36546 ]
            lauren Lauren MacArthur made changes -
            Attachment plot-v1228-base_PsfFluxSn-hist.png [ 36547 ]
            lauren Lauren MacArthur made changes -
            Reviewers Chris Morrison [ cmorrison ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            cmorrison Chris Morrison [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP S19-1 [ 822 ] DRP S19-1, DRP S19-2 [ 822, 840 ]
            lauren Lauren MacArthur made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            yusra Yusra AlSayyad made changes -
            Story Points 3 8
            lauren Lauren MacArthur made changes -
            Link This issue relates to PREOPS-885 [ PREOPS-885 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-32624 [ DM-32624 ]
            lauren Lauren MacArthur made changes -
            lauren Lauren MacArthur made changes -

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Chris Morrison [X] (Inactive)
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, Lauren MacArthur, Paul Price, Robert Lupton, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.