Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17048

Fix handling of ref_cat in gen2convert

    Details

      Description

      We've been accidentally ignoring ref_cat because we didn't have its StorageClass (SimpleCatalog) in Gen3 yet; adding that yields a sequence of (minor) additional problems.

        Attachments

          Activity

          Show
          jbosch Jim Bosch added a comment - https://github.com/lsst/daf_butler/pull/114
          Hide
          nlust Nate Lust added a comment -

          Minor comments. Overall looks good. Not a problem for this ticket, but it would be nice to have a ticket for someone to go back and add a lot of comment lines describing what is happening and why in conceptual terms, as it is hard to do anything but see the code right in front of you with no understanding when someone opens this package.

          Show
          nlust Nate Lust added a comment - Minor comments. Overall looks good. Not a problem for this ticket, but it would be nice to have a ticket for someone to go back and add a lot of comment lines describing what is happening and why in conceptual terms, as it is hard to do anything but see the code right in front of you with no understanding when someone opens this package.
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master.

          Show
          jbosch Jim Bosch added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, Nate Lust
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: