Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17067

Move parsing of dataset-name-substitution option to ctrl_mpexec

    XMLWordPrintable

Details

    • 0.5
    • BG3_F18_11, BG3_S19_01
    • Data Access and Database

    Description

      DM-17060 implements parsing of the value of the option --dataset-name-substitution inside PipelineBuilder class. I think it would be better and more generic for PipelineBuilder to accept a dict and parsing should happen in a cmdLineParser.

      Attachments

        Issue Links

          Activity

            Nate, do you have time to review this small ticket? This continues what you have started on DM-17060, I think this approach should be more general.

            salnikov Andy Salnikov added a comment - Nate, do you have time to review this small ticket? This continues what you have started on DM-17060 , I think this approach should be more general.

            nlust, if you are busy with other tickets I can ask jbosch for review (I want to merge this before big refactoring in ctrl_mpexec).

            salnikov Andy Salnikov added a comment - nlust , if you are busy with other tickets I can ask jbosch for review (I want to merge this before big refactoring in ctrl_mpexec).
            nlust Nate Lust added a comment -

            Sorry I have been a bit busy and had a few other reviews pending before this one that I got though. I may get to it this afternoon, but I can do it for you in the morning for sure. If you need it sooner or jim is free that is fine with me too.

            nlust Nate Lust added a comment - Sorry I have been a bit busy and had a few other reviews pending before this one that I got though. I may get to it this afternoon, but I can do it for you in the morning for sure. If you need it sooner or jim is free that is fine with me too.

            Today/tomorrow is perfect, thanks!

            salnikov Andy Salnikov added a comment - Today/tomorrow is perfect, thanks!
            nlust Nate Lust added a comment -

            One minor comment to help clarify things for the user, but otherwise looks good.

            nlust Nate Lust added a comment - One minor comment to help clarify things for the user, but otherwise looks good.

            Thanks for review! Merged both packages.

            salnikov Andy Salnikov added a comment - Thanks for review! Merged both packages.

            People

              salnikov Andy Salnikov
              salnikov Andy Salnikov
              Nate Lust
              Andy Salnikov, Nate Lust, Vaikunth Thukral
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.